Re: [patch] vectorizer cleanups (and prep for outer-loop vectorization) - part 3/5

[Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>]

Hello,

> > > o A bunch of other cleanups (that are not necessarily inspired by
> > > outer-loop vectorization): Factor out code from
> > > vect_mark_stmts_to_be_vectorized to process_use;
> 
> Tested on the vectorizer testcases
> Bootstrapped and passed full testing on powerpc-linux together with the
> other parts of this patch.
> 
> thanks,
> dorit
> 
> ChangeLog:
> 
>       * tree-vect-analyze.c (process_use): New function.
>       (vect_mark_stmts_to_be_vectorized): Factor out code to process_use.
>       Check phis in all bbs.
>       * tree-vectorizer.c (vect_is_simple_use): Remove redundant checks.

> *************** vect_is_simple_use (tree operand, loop_v
> *** 1730,1742 ****
>       {
>       case PHI_NODE:
>         *def = PHI_RESULT (*def_stmt);
> -       gcc_assert (*dt == vect_induction_def || *dt == vect_reduction_def
> -                   || *dt == vect_invariant_def);
>         break;
>   
>       case GIMPLE_MODIFY_STMT:
>         *def = GIMPLE_STMT_OPERAND (*def_stmt, 0);
> -       gcc_assert (*dt == vect_loop_def || *dt == vect_invariant_def);
>         break;
>   
>       default:
> --- 1721,1730 ----

I would prefer to keep these asserts, unless there is some trivial
reason that makes them redundant (that I do not see).  Otherwise OK.

Zdenek