From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30846 invoked by alias); 12 Apr 2007 12:11:32 -0000 Received: (qmail 30833 invoked by uid 22791); 12 Apr 2007 12:11:31 -0000 X-Spam-Check-By: sourceware.org Received: from atrey.karlin.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 12 Apr 2007 13:11:25 +0100 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 29025) id F10CDC7F79; Thu, 12 Apr 2007 14:11:22 +0200 (CEST) Date: Thu, 12 Apr 2007 12:11:00 -0000 From: Zdenek Dvorak To: Dorit Nuzman Cc: gcc-patches@gcc.gnu.org Subject: Re: [patch] vectorizer cleanups (and prep for outer-loop vectorization) - part 3/5 Message-ID: <20070412121122.GA8089@atrey.karlin.mff.cuni.cz> References: <20070402094812.GA12138@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-04/txt/msg00640.txt.bz2 Hello, > > > o A bunch of other cleanups (that are not necessarily inspired by > > > outer-loop vectorization): Factor out code from > > > vect_mark_stmts_to_be_vectorized to process_use; > > Tested on the vectorizer testcases > Bootstrapped and passed full testing on powerpc-linux together with the > other parts of this patch. > > thanks, > dorit > > ChangeLog: > > * tree-vect-analyze.c (process_use): New function. > (vect_mark_stmts_to_be_vectorized): Factor out code to process_use. > Check phis in all bbs. > * tree-vectorizer.c (vect_is_simple_use): Remove redundant checks. > *************** vect_is_simple_use (tree operand, loop_v > *** 1730,1742 **** > { > case PHI_NODE: > *def = PHI_RESULT (*def_stmt); > - gcc_assert (*dt == vect_induction_def || *dt == vect_reduction_def > - || *dt == vect_invariant_def); > break; > > case GIMPLE_MODIFY_STMT: > *def = GIMPLE_STMT_OPERAND (*def_stmt, 0); > - gcc_assert (*dt == vect_loop_def || *dt == vect_invariant_def); > break; > > default: > --- 1721,1730 ---- I would prefer to keep these asserts, unless there is some trivial reason that makes them redundant (that I do not see). Otherwise OK. Zdenek