* PATCH: PR target/31628: stdcall function is miscompiled
@ 2007-05-18 15:58 H. J. Lu
2007-05-18 19:17 ` Janis Johnson
0 siblings, 1 reply; 4+ messages in thread
From: H. J. Lu @ 2007-05-18 15:58 UTC (permalink / raw)
To: gcc-patches; +Cc: rth
The patch for
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31628
breaks Linux/x86-64:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31989
This patch adds a testcase for PR 31628. OK to install on mainline?
H.J.
---
2007-05-18 H.J. Lu <hongjiu.lu@intel.com>
PR target/31628
* gcc.target/i386/pr31628.c: New.
--- gcc/testsuite/gcc.target/i386/pr31628.c.foo 2007-05-18 08:52:06.000000000 -0700
+++ gcc/testsuite/gcc.target/i386/pr31628.c 2007-05-18 08:50:26.000000000 -0700
@@ -0,0 +1,24 @@
+/* { dg-do run } */
+/* { dg-require-effective-target ilp32 } */
+/* { dg-options "-m32 -fPIC -O2" } */
+
+typedef int tt, *lptt;
+
+int __attribute__((__stdcall__)) bar(lptt);
+
+int __attribute__((__stdcall__)) bar(tt *x)
+{
+ return 0;
+}
+
+int
+foo (void)
+{
+ return bar (0);
+}
+
+int
+main()
+{
+ return foo ();
+}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: PATCH: PR target/31628: stdcall function is miscompiled
2007-05-18 15:58 PATCH: PR target/31628: stdcall function is miscompiled H. J. Lu
@ 2007-05-18 19:17 ` Janis Johnson
2007-05-18 19:31 ` H. J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Janis Johnson @ 2007-05-18 19:17 UTC (permalink / raw)
To: H. J. Lu; +Cc: gcc-patches, rth
On Fri, May 18, 2007 at 08:57:48AM -0700, H. J. Lu wrote:
> --- gcc/testsuite/gcc.target/i386/pr31628.c.foo 2007-05-18 08:52:06.000000000 -0700
> +++ gcc/testsuite/gcc.target/i386/pr31628.c 2007-05-18 08:50:26.000000000 -0700
> @@ -0,0 +1,24 @@
> +/* { dg-do run } */
> +/* { dg-require-effective-target ilp32 } */
> +/* { dg-options "-m32 -fPIC -O2" } */
Don't use -m32 in a test. In this case it's particularly redundant
because the previous directive is already skipping the test if the
current effective target isn't ilp32.
Janis
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: PATCH: PR target/31628: stdcall function is miscompiled
2007-05-18 19:17 ` Janis Johnson
@ 2007-05-18 19:31 ` H. J. Lu
0 siblings, 0 replies; 4+ messages in thread
From: H. J. Lu @ 2007-05-18 19:31 UTC (permalink / raw)
To: Janis Johnson; +Cc: gcc-patches, rth
On Fri, May 18, 2007 at 12:16:58PM -0700, Janis Johnson wrote:
> On Fri, May 18, 2007 at 08:57:48AM -0700, H. J. Lu wrote:
> > --- gcc/testsuite/gcc.target/i386/pr31628.c.foo 2007-05-18 08:52:06.000000000 -0700
> > +++ gcc/testsuite/gcc.target/i386/pr31628.c 2007-05-18 08:50:26.000000000 -0700
> > @@ -0,0 +1,24 @@
> > +/* { dg-do run } */
> > +/* { dg-require-effective-target ilp32 } */
> > +/* { dg-options "-m32 -fPIC -O2" } */
>
> Don't use -m32 in a test. In this case it's particularly redundant
> because the previous directive is already skipping the test if the
> current effective target isn't ilp32.
I checked it in without -m32.
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH: PR target/31628: stdcall function is miscompiled
@ 2007-05-18 18:44 Uros Bizjak
0 siblings, 0 replies; 4+ messages in thread
From: Uros Bizjak @ 2007-05-18 18:44 UTC (permalink / raw)
To: GCC Patches; +Cc: H. J. Lu, Richard Henderson
Hello!
> This patch adds a testcase for PR 31628. OK to install on mainline?
>
>
> H.J.
> ---
> 2007-05-18 H.J. Lu <hongjiu.lu@intel.com>
>
> PR target/31628
> * gcc.target/i386/pr31628.c: New.
This is OK for mainline.
Thanks,
Uros.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-18 19:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-18 15:58 PATCH: PR target/31628: stdcall function is miscompiled H. J. Lu
2007-05-18 19:17 ` Janis Johnson
2007-05-18 19:31 ` H. J. Lu
2007-05-18 18:44 Uros Bizjak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).