[PING] real.c: Remove hexfloat middle-end support

[PING] real.c: Remove hexfloat middle-end support

[Andreas Krebbel]

Hi,

could someone please have a look at the following patch:

http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00963.html

Bye,

-Andreas-

Re: [PING] real.c: Remove hexfloat middle-end support

[Richard Guenther]

On 5/21/07, Andreas Krebbel <Andreas.Krebbel@de.ibm.com> wrote:
> Hi,
>
> could someone please have a look at the following patch:
>
> http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00963.html
>

This is ok for mainline.

Thanks,
Richard.

Re: [PING] real.c: Remove hexfloat middle-end support

[Eric Botcazou]

> could someone please have a look at the following patch:
>
> http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00963.html

It breaks Ada bootstrap:

gcc32 -c   -g -fkeep-inline-functions -DIN_GCC   -W -Wall -Wwrite-strings 
-Wstrict-prototypes -Wmissing-prototypes     -fno-common   -DHAVE_CONFIG_H 
-I. -Iada -I/home/eric/gnat/gnat-head/src/gcc 
-I/home/eric/gnat/gnat-head/src/gcc/ada 
-I/home/eric/gnat/gnat-head/src/gcc/../include 
-I/home/eric/gnat/gnat-head/src/gcc/../libcpp/include  
-I/home/eric/gnat/gnat-head/src/gcc/../libdecnumber 
-I/home/eric/gnat/gnat-head/src/gcc/../libdecnumber/dpd 
-I../libdecnumber    /home/eric/gnat/gnat-head/src/gcc/ada/misc.c -o 
ada/misc.o
/home/eric/gnat/gnat-head/src/gcc/ada/misc.c: In function `enumerate_modes':
/home/eric/gnat/gnat-head/src/gcc/ada/misc.c:919: error: structure has no 
member named `log2_b'
make[3]: *** [ada/misc.o] Error 1

-- 
Eric Botcazou

Re: [PING] real.c: Remove hexfloat middle-end support

[Andrew Pinski]

On 5/21/07, Eric Botcazou <ebotcazou@adacore.com> wrote:
> > could someone please have a look at the following patch:
> >
> > http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00963.html
>
> It breaks Ada bootstrap:
>
> gcc32 -c   -g -fkeep-inline-functions -DIN_GCC   -W -Wall -Wwrite-strings
> -Wstrict-prototypes -Wmissing-prototypes     -fno-common   -DHAVE_CONFIG_H
> -I. -Iada -I/home/eric/gnat/gnat-head/src/gcc
> -I/home/eric/gnat/gnat-head/src/gcc/ada
> -I/home/eric/gnat/gnat-head/src/gcc/../include
> -I/home/eric/gnat/gnat-head/src/gcc/../libcpp/include
> -I/home/eric/gnat/gnat-head/src/gcc/../libdecnumber
> -I/home/eric/gnat/gnat-head/src/gcc/../libdecnumber/dpd
> -I../libdecnumber    /home/eric/gnat/gnat-head/src/gcc/ada/misc.c -o
> ada/misc.o
> /home/eric/gnat/gnat-head/src/gcc/ada/misc.c: In function `enumerate_modes':
> /home/eric/gnat/gnat-head/src/gcc/ada/misc.c:919: error: structure has no
> member named `log2_b'

And this should be easy to fix as log2_b was always one after the
removal of hexfloat support.  I can test the change tomorrow if nobody
else has gotten to it yet.  Note the real line number is 899.

Thanks,
Andrew Pinski

Re: [PING] real.c: Remove hexfloat middle-end support

[Alexandre Oliva]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

On May 21, 2007, Andreas Krebbel <Andreas.Krebbel@de.ibm.com> wrote:

> http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00963.html

This breaks Ada.  The following patch fixes it.  I'm going ahead and
checking it in as obvious.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gcc-real-ada-misc.patch --]
[-- Type: text/x-patch, Size: 575 bytes --]

Index: gcc/ada/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* misc.c (enumerate_modes): Consider log2_b to always be one.

Index: gcc/ada/misc.c
===================================================================
--- gcc/ada/misc.c.orig	2007-05-14 17:56:24.000000000 -0300
+++ gcc/ada/misc.c	2007-05-22 03:55:06.000000000 -0300
@@ -896,7 +896,7 @@ enumerate_modes (void (*f) (int, int, in
 	{
 	  const struct real_format *fmt = REAL_MODE_FORMAT (inner_mode);
 
-	  mantissa = fmt->p * fmt->log2_b;
+	  mantissa = fmt->p;
 	}
 
       if (!skip_p && j != VOIDmode)

[-- Attachment #3: Type: text/plain, Size: 249 bytes --]


-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}

Re: [PING] real.c: Remove hexfloat middle-end support

[Andreas Krebbel]

> > http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00963.html
> 
> This breaks Ada.  The following patch fixes it.  I'm going ahead and
> checking it in as obvious.
Usually I build with Ada support when testing a patch - obviously not this
time.  I've grepped in gcc/ for log2_b and Ada should have been the
last user.

Sorry for the breakage and thanks for taking care of this.

Bye,

-Andreas-