From: "H. J. Lu" <hjl@lucon.org>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: gcc-patches@gcc.gnu.org, dannysmith@users.sourceforge.net
Subject: Re: Your mangle_decl_assembler_name change broke "unaffected" targets.
Date: Thu, 24 May 2007 14:45:00 -0000 [thread overview]
Message-ID: <20070524143401.GA24473@lucon.org> (raw)
In-Reply-To: <200705241211.l4OCBuco020074@ignucius.se.axis.com>
On Thu, May 24, 2007 at 02:11:56PM +0200, Hans-Peter Nilsson wrote:
> (forgot to CC:, originally sent to dannysmith)
>
> You really should have tested on a target that shouldn't have
> been affected by your change; I believe all of them broke.
>
> Index: target-def.h
>
> +#ifndef TARGET_MANGLE_DECL_ASSEMBLER_NAME
> +#define TARGET_MANGLE_DECL_ASSEMBLER_NAME mangle_decl_assembler_name
> +#endif
> +
>
> I think that should have been default_mangle_decl_assembler_name
I saw
2007-05-24 Danny Smith <dannysmith@users.sourceforge.net>
PR target/27067
* doc/tm.texi (TARGET_MANGLE_DECL_ASSEMBLER_NAME): Document.
* targhooks.h (default_mangle_decl_assembler_name): Declare
default hook.
* targhooks.c (default_mangle_decl_assembler_name): Define
default hook.
* target-def.h (TARGET_MANGLE_DECL_ASSEMBLER_NAME) New. Set to
default hook.
I am checking in this patch:
2007-05-24 H.J. Lu <hongjiu.lu@intel.com>
* target-def.h (TARGET_MANGLE_DECL_ASSEMBLER_NAME): Correct
default hook.
--- gcc/target-def.h.hook 2007-05-24 06:33:42.000000000 -0700
+++ gcc/target-def.h 2007-05-24 07:29:39.000000000 -0700
@@ -465,7 +465,7 @@ Foundation, 51 Franklin Street, Fifth Fl
#endif
#ifndef TARGET_MANGLE_DECL_ASSEMBLER_NAME
-#define TARGET_MANGLE_DECL_ASSEMBLER_NAME mangle_decl_assembler_name
+#define TARGET_MANGLE_DECL_ASSEMBLER_NAME default_mangle_decl_assembler_name
#endif
#ifndef TARGET_ENCODE_SECTION_INFO
prev parent reply other threads:[~2007-05-24 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 12:35 Hans-Peter Nilsson
2007-05-24 14:45 ` H. J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524143401.GA24473@lucon.org \
--to=hjl@lucon.org \
--cc=dannysmith@users.sourceforge.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).