* Your mangle_decl_assembler_name change broke "unaffected" targets.
@ 2007-05-24 12:35 Hans-Peter Nilsson
2007-05-24 14:45 ` H. J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Hans-Peter Nilsson @ 2007-05-24 12:35 UTC (permalink / raw)
To: gcc-patches
(forgot to CC:, originally sent to dannysmith)
You really should have tested on a target that shouldn't have
been affected by your change; I believe all of them broke.
Index: target-def.h
+#ifndef TARGET_MANGLE_DECL_ASSEMBLER_NAME
+#define TARGET_MANGLE_DECL_ASSEMBLER_NAME mangle_decl_assembler_name
+#endif
+
I think that should have been default_mangle_decl_assembler_name
because now cris-elf is broken (125018:125020) with:
gcc -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wmissing-format-attribute -fno-common -DHAVE_CONFIG_H -I. -I. -I/tmp/hpautotest-gcc1/gcc/gcc -I/tmp/hpautotest-gcc1/gcc/gcc/. -I/tmp/hpautotest-gcc1/gcc/gcc/../include -I/tmp/hpautotest-gcc1/gcc/gcc/../libcpp/include -I/tmp/hpautotefailed: No such file or directory
st-gcc1/cris-elf/gccobj/./gmp -I/tmp/hpautotest-gcc1/gcc/gmp -I/tmp/hpautotest-gcc1/cris-elf/gccobj/./mpfr -I/tmp/hpautotest-gcc1/gcc/mpfr -I/tmp/hpautotest-gcc1/gcc/gcc/../libdecnumber -I/tmp/hpautotest-gcc1/gcc/gcc/../libdecnumber/dpd -I../libdecnumber \
/tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c -o cris.o
/tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:189: error: 'mangle_decl_assembler_name' undeclared here (not in a function)
make[2]: *** [cris.o] Error 1
brgds, H-P
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Your mangle_decl_assembler_name change broke "unaffected" targets.
2007-05-24 12:35 Your mangle_decl_assembler_name change broke "unaffected" targets Hans-Peter Nilsson
@ 2007-05-24 14:45 ` H. J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H. J. Lu @ 2007-05-24 14:45 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: gcc-patches, dannysmith
On Thu, May 24, 2007 at 02:11:56PM +0200, Hans-Peter Nilsson wrote:
> (forgot to CC:, originally sent to dannysmith)
>
> You really should have tested on a target that shouldn't have
> been affected by your change; I believe all of them broke.
>
> Index: target-def.h
>
> +#ifndef TARGET_MANGLE_DECL_ASSEMBLER_NAME
> +#define TARGET_MANGLE_DECL_ASSEMBLER_NAME mangle_decl_assembler_name
> +#endif
> +
>
> I think that should have been default_mangle_decl_assembler_name
I saw
2007-05-24 Danny Smith <dannysmith@users.sourceforge.net>
PR target/27067
* doc/tm.texi (TARGET_MANGLE_DECL_ASSEMBLER_NAME): Document.
* targhooks.h (default_mangle_decl_assembler_name): Declare
default hook.
* targhooks.c (default_mangle_decl_assembler_name): Define
default hook.
* target-def.h (TARGET_MANGLE_DECL_ASSEMBLER_NAME) New. Set to
default hook.
I am checking in this patch:
2007-05-24 H.J. Lu <hongjiu.lu@intel.com>
* target-def.h (TARGET_MANGLE_DECL_ASSEMBLER_NAME): Correct
default hook.
--- gcc/target-def.h.hook 2007-05-24 06:33:42.000000000 -0700
+++ gcc/target-def.h 2007-05-24 07:29:39.000000000 -0700
@@ -465,7 +465,7 @@ Foundation, 51 Franklin Street, Fifth Fl
#endif
#ifndef TARGET_MANGLE_DECL_ASSEMBLER_NAME
-#define TARGET_MANGLE_DECL_ASSEMBLER_NAME mangle_decl_assembler_name
+#define TARGET_MANGLE_DECL_ASSEMBLER_NAME default_mangle_decl_assembler_name
#endif
#ifndef TARGET_ENCODE_SECTION_INFO
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-24 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-24 12:35 Your mangle_decl_assembler_name change broke "unaffected" targets Hans-Peter Nilsson
2007-05-24 14:45 ` H. J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).