Re: [PATCH]: PR middle-end/30250, use MPFR for lgamma_r/gamma_r

[Janis Johnson <janis187@us.ibm.com>]

On Thu, May 24, 2007 at 05:09:11PM -0400, Kaveh R. GHAZI wrote:
> On Thu, 24 May 2007, Janis Johnson wrote:
> 
> > On Thu, May 24, 2007 at 10:15:22AM +0200, Richard Guenther wrote:
> > > On 5/24/07, Richard Guenther <richard.guenther@gmail.com> wrote:
> > > >On 5/24/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> > > >> On Wed, 23 May 2007, Richard Guenther wrote:
> > > >>
> > > >> > This:
> > > >> >
> > > >> > /* Expect failures at least until mpfr-2.3.0 is released. */
> > > >> > /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */
> > > >> >
> > > >> > doesn't work.  Or did you forget a testsuite/lib patch?
> >
> > This should be:
> >   /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } { "*" } { "" } } */
> > The "mpfr-2.3.0" is a comment.  The lists of included and excluded
> > options are not optional; I'm surprised it works.
> > > Updating to dejagnu 1.4.4 fixed it.  Luckily that still works with old tcl
> > > ;)
> > Magic.
> > Janis
> 
> Oh okay, I thought those flags were optional because I saw it like that
> somewhere else (and of course it passed my own testing).  Search, search,
> search... ah, here's one:  gcc.dg/Warray-bounds.c.
> 
> Anyway, I'm happy to fix the one I introduced.  I also made the comment
> more verbose to clarify that it is in fact a comment and not some magic
> pattern search for an mpfr version.
> 
> Tested via "make check" using mpfr-2.2.1 and mpfr-2.3.0-svn.  I still get
> XFAIL and XPASS respectively as desired.
> 
> Okay for mainline?

Yes, thanks.

Janis