From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31772 invoked by alias); 24 May 2007 22:28:40 -0000 Received: (qmail 31749 invoked by uid 22791); 24 May 2007 22:28:30 -0000 X-Spam-Check-By: sourceware.org Received: from e2.ny.us.ibm.com (HELO e2.ny.us.ibm.com) (32.97.182.142) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 May 2007 22:28:29 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l4OMSRkd002024 for ; Thu, 24 May 2007 18:28:27 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4OMSRC7546030 for ; Thu, 24 May 2007 18:28:27 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4OMSQsR011090 for ; Thu, 24 May 2007 18:28:27 -0400 Received: from dyn9047018100.beaverton.ibm.com (dyn9047018100.beaverton.ibm.com [9.47.18.100]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l4OMSPA2011072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 May 2007 18:28:26 -0400 Received: from dyn9047018100.beaverton.ibm.com (localhost.localdomain [127.0.0.1]) by dyn9047018100.beaverton.ibm.com (8.12.8/8.12.8) with ESMTP id l4OMSNKC006813; Thu, 24 May 2007 15:28:23 -0700 Received: (from janis@localhost) by dyn9047018100.beaverton.ibm.com (8.12.8/8.12.8/Submit) id l4OMSMfU006811; Thu, 24 May 2007 15:28:22 -0700 Date: Thu, 24 May 2007 22:43:00 -0000 From: Janis Johnson To: "Kaveh R. GHAZI" Cc: Janis Johnson , Richard Guenther , gcc-patches@gcc.gnu.org, Joe.Buck@synopsys.com Subject: Re: [PATCH]: PR middle-end/30250, use MPFR for lgamma_r/gamma_r Message-ID: <20070524222822.GA6801@us.ibm.com> References: <84fc9c000705170315g15b30422ga7884f0779c17003@mail.gmail.com> <84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com> <84fc9c000705240111t86aedf6r40023d76a1c8a0c5@mail.gmail.com> <84fc9c000705240115g84900bdgbcbdb1c5ae21b760@mail.gmail.com> <20070524164644.GA4287@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-05/txt/msg01662.txt.bz2 On Thu, May 24, 2007 at 05:09:11PM -0400, Kaveh R. GHAZI wrote: > On Thu, 24 May 2007, Janis Johnson wrote: > > > On Thu, May 24, 2007 at 10:15:22AM +0200, Richard Guenther wrote: > > > On 5/24/07, Richard Guenther wrote: > > > >On 5/24/07, Kaveh R. GHAZI wrote: > > > >> On Wed, 23 May 2007, Richard Guenther wrote: > > > >> > > > >> > This: > > > >> > > > > >> > /* Expect failures at least until mpfr-2.3.0 is released. */ > > > >> > /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */ > > > >> > > > > >> > doesn't work. Or did you forget a testsuite/lib patch? > > > > This should be: > > /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } { "*" } { "" } } */ > > The "mpfr-2.3.0" is a comment. The lists of included and excluded > > options are not optional; I'm surprised it works. > > > Updating to dejagnu 1.4.4 fixed it. Luckily that still works with old tcl > > > ;) > > Magic. > > Janis > > Oh okay, I thought those flags were optional because I saw it like that > somewhere else (and of course it passed my own testing). Search, search, > search... ah, here's one: gcc.dg/Warray-bounds.c. > > Anyway, I'm happy to fix the one I introduced. I also made the comment > more verbose to clarify that it is in fact a comment and not some magic > pattern search for an mpfr version. > > Tested via "make check" using mpfr-2.2.1 and mpfr-2.3.0-svn. I still get > XFAIL and XPASS respectively as desired. > > Okay for mainline? Yes, thanks. Janis