public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: "Vladimir N. Makarov" <vmakarov@redhat.com>,
		Steven Bosscher <stevenb.gcc@gmail.com>,
		gcc-patches <gcc-patches@gcc.gnu.org>,
	richard@codesourcery.com
Subject: Re: dataflow branch merging plans.
Date: Fri, 25 May 2007 18:21:00 -0000	[thread overview]
Message-ID: <20070525180045.GC13382@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <87veegyjp8.fsf@firetop.home>

> "Vladimir N. Makarov" <vmakarov@redhat.com> writes:
> > <stevenb> honza: you know vlad... he has great ideas, in theory, but there's a reason why he never manages to actually finish something properly ;-)
> > <honza> hmm, for example dfa automatos does their job relatively well...
> > <stevenb> ...if you're willing to accept that:
> > <stevenb> a) it takes 30% of the total compile time
> > <stevenb> b) all the good parts are written by zack
> > <stevenb> c) all the scheduler descriptions except itanium are written by me
> > <stevenb> (oh, and mips, which paolo bonzini took care of)
> 
> I know this wasn't meant to be taken seriously, but since Vlad has
> already dissed (a) and (b), I don't think (c) is true either.

Because I was quoted above, I guess I should also add that I like the
Vladimir's work.  I familiarized myself with the automaton generation
code when I needed to speed it up to get Athlon machine description
generated in resonable time and I think I know what I am speaking about
when I say that it is very nice piece of work. It was definitly hard to
implement and the problems that occured after merge was relatively
little given the complexity of project (and I probably should've
commented more on the IRC originally).  Overall I think Vladimir work is
of very good quality, a lot of it seems to end up unmerged because it
don't seems to meet orignal expectations that might be a pity as the
code might be useful anyway. (However not every developer has enought of
discipline to drop a code he spent a lot of work on when it don't seems
to do what it was supposed to very well.) DFA or new YARA are definitly
dificult projects and I am happy we have someone who can track them
down.

In general it seems to me that there is a conflict of development
philosphies.  While Vladimir is trying to get his project done to the
degree that they are stable and overall win before merging, proposed
dataflow merge is on different basis.  Main motivation for dataflow
merge seems to be that there seems to be overall agreement that we want
a new dataflow implementation and further delaying the merge don't seem
to make it significantly more ready.  It up to us, other developers,
whether we want to take responsibility to get it done for 4.3 to the
level so it is not causing compilation time, memory or wrong code bugs.

This scheme seemed to wrok for tree-SSA and might be only way to deal
with some of very dificult projects.  (Even though I am trying to merge
my larger projects when they are done, I had similar merge with original
cgraph unit-at-a-time implementation that caused a lot more problems
that I would anticipated at that time). So I would suggest to give it a
try with dataflow too. I see only other sensible option to drop it
completely that would be IMO a considerable mistake, as we will need to
modernize RTL backend sooner or later and there don't seem to be
anything fundamentally wrong with dataflow branch design as far as I can
tell. So as I admire the Vladimir's work, I admire the efforts put to
dataflow as well.

Honza

  reply	other threads:[~2007-05-25 18:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 13:19 Kenneth Zadeck
2007-05-24  1:29 ` Andrew_Pinski
2007-05-24  7:51   ` Paolo Bonzini
2007-05-24  8:12     ` Paolo Bonzini
2007-05-24 11:47 ` Bernd Schmidt
2007-05-24 20:02   ` Kenneth Zadeck
2007-05-25  9:51     ` Bernd Schmidt
2007-05-25 10:32       ` Paolo Bonzini
2007-05-25 13:00       ` Kenneth Zadeck
2007-05-28 20:55       ` Mark Mitchell
2007-05-29  1:16         ` Kenneth Zadeck
2007-05-29 15:58           ` Mark Mitchell
2007-05-24 21:09   ` Steven Bosscher
2007-05-24 22:23     ` Vladimir N. Makarov
2007-05-24 23:03       ` Steven Bosscher
2007-05-25 13:50         ` Vladimir N. Makarov
2007-05-25 17:15           ` Richard Sandiford
2007-05-25 18:21             ` Jan Hubicka [this message]
2007-05-25 20:13             ` Steven Bosscher
2007-05-25 20:11           ` Steven Bosscher
     [not found] <OF781E582C.3916D180-ON882572E5.00078CD6-882572E5.00082C95@LocalDomain>
2007-05-25  0:12 ` Andrew_Pinski
2007-05-25 19:04 Zack Weinberg
     [not found] <OF1BD0F1DA.E933CF3F-ON422572E9.006B2EF9-422572E9.006B85BF@de.ibm.com>
2007-05-29  1:05 ` Kenneth Zadeck
2007-05-30 13:11   ` Andreas Krebbel1
2007-05-30 14:17     ` Kenneth Zadeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525180045.GC13382@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard@codesourcery.com \
    --cc=stevenb.gcc@gmail.com \
    --cc=vmakarov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).