[PATCH, rtl]: Print note insn names in RTL dumps

[PATCH, rtl]: Print note insn names in RTL dumps

[Uros Bizjak]

Hello!

Since r124859 [1], NOTE_INSN names are not printed anymore in RTL
dumps. Attached patch re-introduces them into the dumps.

Patch was bootstrapped/regtested on i686-pc-linux-gnu. Additionally, a
large c++ application was compiled using -da.

2007-07-05  Uros Bizjak  <ubizjak@gmail.com>

	* rtl.def (NOTE): Change print format string to print
	operand 5 as a note insn name.

OK for mainline?

[1] http://gcc.gnu.org/ml/gcc-cvs/2007-05/msg00594.html

Index: rtl.def
===================================================================
--- rtl.def     (revision 126361)
+++ rtl.def     (working copy)
@@ -140,9 +140,9 @@
 /* Say where in the code a source line starts, for symbol table's sake.
    Operand:
    4: note-specific data
-   5: unused (memory layout has to match code_label above)
+   5: enum insn_note
    6: unique number if line number == note_insn_deleted_label.  */
-DEF_RTL_EXPR(NOTE, "note", "iuuB00i", RTX_EXTRA)
+DEF_RTL_EXPR(NOTE, "note", "iuuB0ni", RTX_EXTRA)

 /* ----------------------------------------------------------------------
    Top level constituents of INSN, JUMP_INSN and CALL_INSN.

Re: [PATCH, rtl]: Print note insn names in RTL dumps

[Jan Hubicka]

> Hello!
> 
> Since r124859 [1], NOTE_INSN names are not printed anymore in RTL
> dumps. Attached patch re-introduces them into the dumps.
> 
> Patch was bootstrapped/regtested on i686-pc-linux-gnu. Additionally, a
> large c++ application was compiled using -da.

Oops, thanks for fixing it.  I somehow misread the memory representation
thinking that there is one extra field used for saving file name that 
in reality was overlaping with note specific data.

> 
> 2007-07-05  Uros Bizjak  <ubizjak@gmail.com>
> 
> 	* rtl.def (NOTE): Change print format string to print
> 	operand 5 as a note insn name.
> 
> OK for mainline?

I would declare it as obvious...
Honza

Re: [PATCH, rtl]: Print note insn names in RTL dumps

[Mark Mitchell]

Jan Hubicka wrote:

>> 2007-07-05  Uros Bizjak  <ubizjak@gmail.com>
>>
>> 	* rtl.def (NOTE): Change print format string to print
>> 	operand 5 as a note insn name.
>>
>> OK for mainline?
> 
> I would declare it as obvious...

For avoidance of doubt, this is OK.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713