From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20870 invoked by alias); 5 Jul 2007 17:30:04 -0000 Received: (qmail 20806 invoked by uid 22791); 5 Jul 2007 17:30:02 -0000 X-Spam-Check-By: sourceware.org Received: from sccrmhc15.comcast.net (HELO sccrmhc15.comcast.net) (204.127.200.85) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jul 2007 17:29:51 +0000 Received: from lucon.org ([24.6.230.138]) by comcast.net (sccrmhc15) with ESMTP id <2007070517295001500j269me>; Thu, 5 Jul 2007 17:29:50 +0000 Received: by lucon.org (Postfix, from userid 500) id AA37DF81DA; Thu, 5 Jul 2007 10:29:49 -0700 (PDT) Date: Thu, 05 Jul 2007 17:41:00 -0000 From: "H.J. Lu" To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org Subject: Re: PATCH: Add myself as libbid maintainer Message-ID: <20070705172949.GA5912@lucon.org> References: <20070705131151.GA10780@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.14 (2007-02-12) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg00467.txt.bz2 On Thu, Jul 05, 2007 at 09:46:27AM -0700, Ian Lance Taylor wrote: > "H.J. Lu" writes: > > > I am checking in this patch to add myself as libbid maintainer. > > Normally changes to the list of maintainers are approved by the > steering committee. I didn't see any notice about this one. I would > just like to confirm that this change was approved. I thought libbid in gcc needed a maintainer. It was my mistake. I will remove myself. Sorry for that. > > I'm also uncertain as to just who approved the commit of > libgcc/config/libbid into mainline. When I look at the code I see http://gcc.gnu.org/ml/gcc/2007-06/msg00457.html http://gcc.gnu.org/ml/gcc/2007-06/msg00491.html Both x86 maintainer and build/libgcc maintainer reviewed the patch. > that it is not formatted to the GNU standard, and it includes C++ > style comments which we do not normally use in C code. This library is a general BID library developed at Intel, not just for gcc. Can we have an exception or some compromise? > > I'm also uncertain as to the relationship of the code in gcc mainline > and the code at Intel. This code was written at Intel and I see there > is now a ChangeLog entry which starts > Updated from Intel BID library: > Where can the Intel BID library sources be found? What license is it > under? What should happen with changes that we want to make to the > libbid sources now in mainline? Should we send them back to Intel? > > I see that bid_intrinsics.h has a #ifdef IN_LIBGCC2 which seems > redundant for code that is in libgcc. The beta Intel BID library was announced at http://gcc.gnu.org/ml/gcc/2007-04/msg00903.html which has a BSD license. The one submitted to gcc is under GPL v2 + exception. This library isn't just for libgcc. We'd like to keep libbid in gcc as close to Intel BID library as possible. I would prefer bug to be fixed in Intel BID library first if all possible. We should track gcc libbid bugs in gcc bugzilla. We can add a new libbid component and assign all libbid bugs to me. H.J.