* Re: [PATCH] Fix pragma-darwin.c (and turn on for i386-darwin also)
@ 2007-07-29 23:52 Dominique Dhumieres
0 siblings, 0 replies; 4+ messages in thread
From: Dominique Dhumieres @ 2007-07-29 23:52 UTC (permalink / raw)
To: gcc-patches
> OK? Tested on i386-darwin with no regressions.
I have tested it on powerpc-darwin with no regressions.
Dominique
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fix pragma-darwin.c (and turn on for i386-darwin also)
@ 2007-07-29 22:24 Andrew Pinski
2007-07-29 23:09 ` Andrew Pinski
2007-07-30 18:34 ` Janis Johnson
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Pinski @ 2007-07-29 22:24 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
Hi,
This path fixes the testcase for the dg-error/dg-warning change so
that the warnings are now marked with dg-warning. This patch also
turns on this testcase for i386-darwin.
OK? Tested on i386-darwin with no regressions.
Thanks,
Andrew Pinski
[-- Attachment #2: fixpragma-darwin.c.diff.txt --]
[-- Type: text/plain, Size: 1872 bytes --]
Index: gcc.dg/pragma-darwin.c
===================================================================
--- gcc.dg/pragma-darwin.c (revision 127042)
+++ gcc.dg/pragma-darwin.c (working copy)
@@ -1,6 +1,6 @@
/* Darwin (Mac OS X) pragma exercises. */
-/* { dg-do run { target powerpc-*-darwin* } } */
+/* { dg-do run { target *-*-darwin* } } */
/* { dg-options "-O -Wunused" } */
/* The mark pragma is to help decorate IDEs. */
@@ -12,11 +12,11 @@
/* The options pragma used to do a lot, now it's only for emulating
m68k alignment rules in structs. */
-#pragma options 23 /* { dg-error "malformed '#pragma options'" } */
-#pragma options align /* { dg-error "malformed '#pragma options'" } */
-#pragma options align natural /* { dg-error "malformed '#pragma options'" } */
-#pragma options align=45 /* { dg-error "malformed '#pragma options'" } */
-#pragma options align=foo /* { dg-error "malformed '#pragma options align" } */
+#pragma options 23 /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align natural /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align=45 /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align=foo /* { dg-warning "malformed '#pragma options align" } */
#ifndef __LP64__
#pragma options align=mac68k
@@ -64,7 +64,7 @@
{
int a, b;
/* Trying to match on '(' or ')' gives regexp headaches, use . instead. */
-#pragma unused /* { dg-error "missing '.' after '#pragma unused" } */
-#pragma unused (a /* { dg-error "missing '.' after '#pragma unused" } */
+#pragma unused /* { dg-warning "missing '.' after '#pragma unused" } */
+#pragma unused (a /* { dg-warning "missing '.' after '#pragma unused" } */
#pragma unused (b) foo /* { dg-warning "junk at end of '#pragma unused'" } */
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix pragma-darwin.c (and turn on for i386-darwin also)
2007-07-29 22:24 Andrew Pinski
@ 2007-07-29 23:09 ` Andrew Pinski
2007-07-30 18:34 ` Janis Johnson
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Pinski @ 2007-07-29 23:09 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On 7/29/07, Andrew Pinski <pinskia@gmail.com> wrote:
> Hi,
> This path fixes the testcase for the dg-error/dg-warning change so
> that the warnings are now marked with dg-warning. This patch also
> turns on this testcase for i386-darwin.
>
> OK? Tested on i386-darwin with no regressions.
I knew I forgot something, the changelog:
* gcc.dg/pragma-darwin.c: Run on all *-*-darwin* targets.
s/dg-error/dg-warning where warning is expected.
Thanks,
Andrew Pinski
[-- Attachment #2: fixpragma-darwin.c.diff.txt --]
[-- Type: text/plain, Size: 1872 bytes --]
Index: gcc.dg/pragma-darwin.c
===================================================================
--- gcc.dg/pragma-darwin.c (revision 127042)
+++ gcc.dg/pragma-darwin.c (working copy)
@@ -1,6 +1,6 @@
/* Darwin (Mac OS X) pragma exercises. */
-/* { dg-do run { target powerpc-*-darwin* } } */
+/* { dg-do run { target *-*-darwin* } } */
/* { dg-options "-O -Wunused" } */
/* The mark pragma is to help decorate IDEs. */
@@ -12,11 +12,11 @@
/* The options pragma used to do a lot, now it's only for emulating
m68k alignment rules in structs. */
-#pragma options 23 /* { dg-error "malformed '#pragma options'" } */
-#pragma options align /* { dg-error "malformed '#pragma options'" } */
-#pragma options align natural /* { dg-error "malformed '#pragma options'" } */
-#pragma options align=45 /* { dg-error "malformed '#pragma options'" } */
-#pragma options align=foo /* { dg-error "malformed '#pragma options align" } */
+#pragma options 23 /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align natural /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align=45 /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align=foo /* { dg-warning "malformed '#pragma options align" } */
#ifndef __LP64__
#pragma options align=mac68k
@@ -64,7 +64,7 @@
{
int a, b;
/* Trying to match on '(' or ')' gives regexp headaches, use . instead. */
-#pragma unused /* { dg-error "missing '.' after '#pragma unused" } */
-#pragma unused (a /* { dg-error "missing '.' after '#pragma unused" } */
+#pragma unused /* { dg-warning "missing '.' after '#pragma unused" } */
+#pragma unused (a /* { dg-warning "missing '.' after '#pragma unused" } */
#pragma unused (b) foo /* { dg-warning "junk at end of '#pragma unused'" } */
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix pragma-darwin.c (and turn on for i386-darwin also)
2007-07-29 22:24 Andrew Pinski
2007-07-29 23:09 ` Andrew Pinski
@ 2007-07-30 18:34 ` Janis Johnson
1 sibling, 0 replies; 4+ messages in thread
From: Janis Johnson @ 2007-07-30 18:34 UTC (permalink / raw)
To: Andrew Pinski; +Cc: gcc-patches
On Sun, 2007-07-29 at 15:21 -0700, Andrew Pinski wrote:
> Hi,
> This path fixes the testcase for the dg-error/dg-warning change so
> that the warnings are now marked with dg-warning. This patch also
> turns on this testcase for i386-darwin.
>
> OK? Tested on i386-darwin with no regressions.
OK.
Janis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-30 18:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-29 23:52 [PATCH] Fix pragma-darwin.c (and turn on for i386-darwin also) Dominique Dhumieres
-- strict thread matches above, loose matches on Subject: below --
2007-07-29 22:24 Andrew Pinski
2007-07-29 23:09 ` Andrew Pinski
2007-07-30 18:34 ` Janis Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).