From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29257 invoked by alias); 31 Jul 2007 18:20:10 -0000 Received: (qmail 29246 invoked by uid 22791); 31 Jul 2007 18:20:09 -0000 X-Spam-Check-By: sourceware.org Received: from sccrmhc14.comcast.net (HELO sccrmhc14.comcast.net) (63.240.77.84) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 31 Jul 2007 18:20:04 +0000 Received: from lucon.org ([24.6.230.138]) by comcast.net (sccrmhc14) with ESMTP id <200707311820020140017mv9e>; Tue, 31 Jul 2007 18:20:02 +0000 Received: by lucon.org (Postfix, from userid 500) id D39E5F7F58; Tue, 31 Jul 2007 11:20:01 -0700 (PDT) Date: Tue, 31 Jul 2007 18:40:00 -0000 From: "H.J. Lu" To: Janis Johnson Cc: gcc-patches@gcc.gnu.org, echristo@apple.com Subject: Re: PATCH: PR testsuite/32932: ssp tests can't find libssp Message-ID: <20070731182001.GA28810@lucon.org> References: <20070730230359.GA13062@lucon.org> <1185903836.6581.15.camel@janis-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1185903836.6581.15.camel@janis-laptop> User-Agent: Mutt/1.5.14 (2007-02-12) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg02198.txt.bz2 On Tue, Jul 31, 2007 at 10:43:56AM -0700, Janis Johnson wrote: > On Mon, 2007-07-30 at 16:03 -0700, H.J. Lu wrote: > > This patch makes sure that the newly built libssp is used for > > test. Tested on Linux/x86-64. > > The patch doesn't handle multilibs; apparently you didn't test > with both -m32 and -m64. It does support multilibs: @@ -113,6 +114,10 @@ proc gcc_init { args } { set gcc_error_prefix "error:" gcc_maybe_build_wrapper "${tmpdir}/gcc-testglue.o" + + libssp_init [get_multilibs] + + set gcc_initialized 1 } # and I tested with -m32 on Linux/x86-64: Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc -B/export/build/gnu/gcc/build-x86_64-linux/gcc/ /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c -fstack-protector -fno-show-column -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs -lm -m32 -o ./ssp-1.exe (timeout = 300) PASS: gcc.dg/ssp-1.c (test for excess errors) Setting LD_LIBRARY_PATH to :/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs::/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libstdc++-v3/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libmudflap/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libgomp/.libs:/export/build/gnu/gcc/build-x86_64-linux/./gcc:/export/build/gnu/gcc/build-x86_64-linux/./prev-gcc PASS: gcc.dg/ssp-1.c execution test ... Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc -B/export/build/gnu/gcc/build-x86_64-linux/gcc/ /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c -fstack-protector -fno-show-column -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs -lm -o ./ssp-1.exe (timeout = 300) PASS: gcc.dg/ssp-1.c (test for excess errors) Setting LD_LIBRARY_PATH to :/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs::/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libstdc++-v3/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libmudflap/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libgomp/.libs:/export/build/gnu/gcc/build-x86_64-linux/./gcc:/export/build/gnu/gcc/build-x86_64-linux/./prev-gcc PASS: gcc.dg/ssp-1.c execution test > > These tests really ought to be in libssp/testsuite, which doesn't > yet exist, and look for libraries in the same way as other library > testsuites. I've copied Eric Christopher, who added these tests, > to get his opinion about that. > > Setting gcc_initialized doesn't belong in this patch, and should > be tested by running the full testsuite with multiple runs, e.g. > -m32 and -m64, to make sure there are no surprises. Here is my result: http://gcc.gnu.org/ml/gcc-testresults/2007-07/msg01202.html H.J.