From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6812 invoked by alias); 1 Aug 2007 10:00:32 -0000 Received: (qmail 6794 invoked by uid 22791); 1 Aug 2007 10:00:29 -0000 X-Spam-Check-By: sourceware.org Received: from nikam-dmz.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Aug 2007 10:00:27 +0000 Received: from localhost (kampanus.ms.mff.cuni.cz [195.113.18.107]) by nikam.ms.mff.cuni.cz (Postfix) with ESMTP id A4CC35B87E; Wed, 1 Aug 2007 12:00:24 +0200 (CEST) Received: by localhost (Postfix, from userid 16202) id 9E3E4AF57F; Wed, 1 Aug 2007 12:00:24 +0200 (CEST) Date: Wed, 01 Aug 2007 10:00:00 -0000 From: Jan Hubicka To: Kai Tietz Cc: Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: PING: PING: patch: ICE in legitimize_pic_address for x86_64 mingw target Message-ID: <20070801100024.GG20007@kam.mff.cuni.cz> References: <20070731213647.GA28848@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.9i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00019.txt.bz2 > AFAIK there are no quaranteed constant values beside the gs/fs-segment > area in the 64-bit ABI of MS. > So I think the case described by you won't occure, but may I missed > something. > The MS ABI defines base relocations 64-bit wide. There is no 32-bit base > relocation for this target. They have to be PC-relative. But this target > defines PC-relative relocations with 8, 32, and 64 bit width. So I don't > expect problems there. There is no 64bit pc relative addressing mode on x86-64. The code in question is matching base+offset addressing mode that is limited to 32bit signed values. Thinking about it, the generic address legitimizing code is going to work this out, so you probably don't need to care about it. The patch is OK Honza > AA > Cheers, > i.A. Kai Tietz > > | (\_/) This is Bunny. Copy and paste Bunny > | (='.'=) into your signature to help him gain > | (")_(") world domination. > > ------------------------------------------------------------------------------------------ > OneVision Software Entwicklungs GmbH & Co. KG > Dr.-Leo-Ritter-Straße 9 - 93049 Regensburg > Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com > Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050 > Handelsregister: HRA 6744, Amtsgericht Regensburg > Komplementärin: OneVision Software Entwicklungs Verwaltungs GmbH > Dr.-Leo-Ritter-Straße 9 ??? 93049 Regensburg > Handelsregister: HRB 8932, Amtsgericht Regensburg - Geschäftsführer: > Ulrike Döhler, Manuela Kluger >