public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] lower-subreg: Decompose multiword shifts
Date: Fri, 03 Aug 2007 16:41:00 -0000	[thread overview]
Message-ID: <20070803164054.GA9272@blc4eb430604175.ibm.com> (raw)
In-Reply-To: <46B20CB2.7000103@gnu.org>

> +   if (INTVAL (shift_count) < BITS_PER_WORD
> +       || GET_MODE_BITSIZE (GET_MODE (shift_operand)) != 2 * BITS_PER_WORD)
> +     return 0;
> 
> (your code has != in the first branch).  You can turn the code into a 
> move+a shift, which simplifies to two moves if INTVAL (shift_count) == 
> BITS_PER_WORD, in this case.

Sounds like a good idea. Although compared to emitting just move
instructions shifts would be more complex since I probably would need to
use the optab machinery - right?!

Ulrich already proposed to also optimize multiword zeroextends that
way. I'll try to enhance my patch.

Bye,

-Andreas-

  reply	other threads:[~2007-08-03 16:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 15:35 Andreas Krebbel
2007-08-02 16:56 ` Paolo Bonzini
2007-08-03 16:41   ` Andreas Krebbel [this message]
2007-08-03 19:02     ` Paolo Bonzini
2007-08-02 18:52 ` Rask Ingemann Lambertsen
2007-08-02 19:21   ` Andreas Krebbel
2007-08-07  1:41     ` Rask Ingemann Lambertsen
2007-08-07  8:29       ` Andreas Krebbel
2007-08-02 23:16 ` Rask Ingemann Lambertsen
2007-08-03 12:03   ` Michael Matz
2007-08-03 14:34   ` Andreas Krebbel
2007-08-03 15:37     ` Michael Matz
2007-08-07  1:08       ` Ian Lance Taylor
2007-08-07  1:27 ` Ian Lance Taylor
2007-08-07 10:47   ` Andreas Krebbel
2007-08-08 18:40     ` Andreas Tobler
2007-08-09  7:45       ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070803164054.GA9272@blc4eb430604175.ibm.com \
    --to=andreas.krebbel@de.ibm.com \
    --cc=bonzini@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).