Re: top-level configure

Re: top-level configure

[Ralf Wildenhues]

Hello Ben,

* Ben Elliston wrote on Sat, Jul 21, 2007 at 10:33:54PM CEST:
> Before I open a PR for this, I'd like to make sure I'm not doing
> anything wrong .. :-)

I don't think you are.

> It used to be the case that the Cygnus top-level configure script would
> pass any configure options to all subdirectory `configure' invocations.
> Now it doesn't seem to work as I expect when I pass --quiet to the
> top-level configure script.  When I run make, I see configure output
> from fixincludes, etc.

Proposed patch below.  Note I have neither approval nor commit rights,
neither to gcc nor to binutils src, and have only done casual testing.
Please Cc: me on replies.

Cheers,
Ralf

ChangeLog:
2007-07-23  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	* configure.ac (TOPLEVEL_CONFIGURE_ARGUMENTS, baseargs):
	Pass --silent if $silent.

Index: configure.ac
===================================================================
--- configure.ac	(revision 126835)
+++ configure.ac	(working copy)
@@ -101,6 +102,9 @@
   # Add the quoted argument to the list.
   TOPLEVEL_CONFIGURE_ARGUMENTS="$TOPLEVEL_CONFIGURE_ARGUMENTS $ac_arg"
 done
+if test "$silent" = yes; then
+  TOPLEVEL_CONFIGURE_ARGUMENTS="$TOPLEVEL_CONFIGURE_ARGUMENTS --silent"
+fi
 # Remove the initial space we just introduced and, as these will be
 # expanded by make, quote '$'.
 TOPLEVEL_CONFIGURE_ARGUMENTS=`echo "x$TOPLEVEL_CONFIGURE_ARGUMENTS" | sed -e 's/^x *//' -e 's,\\$,$$,g'`
@@ -2178,6 +2183,9 @@
 gcc_transform_name=`cat conftestsed.out`
 rm -f conftestsed.out
 baseargs="$baseargs --program-transform-name='${gcc_transform_name}'"
+if test "$silent" = yes; then
+  baseargs="$baseargs --silent"
+fi
 
 # For the build-side libraries, we just need to pretend we're native,
 # and not use the same cache file.  Multilibs are neither needed nor

Re: top-level configure

[Ralf Wildenhues]

Hello,

a gentle reminder for:
<http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01679.html>

:ADDPATCH configure:

> * Ben Elliston wrote on Sat, Jul 21, 2007 at 10:33:54PM CEST:
> 
> > It used to be the case that the Cygnus top-level configure script would
> > pass any configure options to all subdirectory `configure' invocations.
> > Now it doesn't seem to work as I expect when I pass --quiet to the
> > top-level configure script.
[...]

> ChangeLog:
> 2007-07-23  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
> 
> 	* configure.ac (TOPLEVEL_CONFIGURE_ARGUMENTS, baseargs):
> 	Pass --silent if $silent.
> 
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 126835)
> +++ configure.ac	(working copy)
> @@ -101,6 +102,9 @@
>    # Add the quoted argument to the list.
>    TOPLEVEL_CONFIGURE_ARGUMENTS="$TOPLEVEL_CONFIGURE_ARGUMENTS $ac_arg"
>  done
> +if test "$silent" = yes; then
> +  TOPLEVEL_CONFIGURE_ARGUMENTS="$TOPLEVEL_CONFIGURE_ARGUMENTS --silent"
> +fi
>  # Remove the initial space we just introduced and, as these will be
>  # expanded by make, quote '$'.
>  TOPLEVEL_CONFIGURE_ARGUMENTS=`echo "x$TOPLEVEL_CONFIGURE_ARGUMENTS" | sed -e 's/^x *//' -e 's,\\$,$$,g'`
> @@ -2178,6 +2183,9 @@
>  gcc_transform_name=`cat conftestsed.out`
>  rm -f conftestsed.out
>  baseargs="$baseargs --program-transform-name='${gcc_transform_name}'"
> +if test "$silent" = yes; then
> +  baseargs="$baseargs --silent"
> +fi
>  
>  # For the build-side libraries, we just need to pretend we're native,
>  # and not use the same cache file.  Multilibs are neither needed nor

Re: top-level configure

[DJ Delorie]

> > 2007-07-23  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
> > 
> > 	* configure.ac (TOPLEVEL_CONFIGURE_ARGUMENTS, baseargs):
> > 	Pass --silent if $silent.

Ok.