From: Daniel Jacobowitz <drow@false.org>
To: gcc-patches@gcc.gnu.org
Subject: Re: Fix i686-linux --enable-targets=all
Date: Mon, 06 Aug 2007 13:51:00 -0000 [thread overview]
Message-ID: <20070806135141.GA31444@caradoc.them.org> (raw)
In-Reply-To: <20070806134128.GA11524@lucon.org>
On Mon, Aug 06, 2007 at 06:41:28AM -0700, H.J. Lu wrote:
> It is the part of
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31868
>
> and a complete patch is posted at
>
> http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00563.html
>
> Could someone please review it?
I see. I don't think your patch actually handles this case; you set
CRTSTUFF_T_FLAGS in t-crtstuff64, but i386/t-crtstuff will be included
afterwards, and that will set it again. That's why I did it more
centrally. The problem is the same for any target that forces
creation of .eh_frame; my patch won't affect i386-linux crtend.o even
though it changes the compile flags there.
Also, I think += is preferred.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-06 13:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 13:37 Daniel Jacobowitz
2007-08-06 13:39 ` Andrew Pinski
2007-08-06 13:41 ` H.J. Lu
2007-08-06 13:51 ` Daniel Jacobowitz [this message]
2007-08-06 14:13 ` H.J. Lu
2007-08-06 14:24 ` Daniel Jacobowitz
2007-08-06 14:56 ` H.J. Lu
2007-08-06 15:07 ` Daniel Jacobowitz
2007-08-06 16:05 ` Paolo Bonzini
2007-08-06 16:11 ` Daniel Jacobowitz
2007-08-06 16:29 ` H.J. Lu
2007-08-06 18:34 Paolo Bonzini
2007-08-06 19:53 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806135141.GA31444@caradoc.them.org \
--to=drow@false.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).