Re: Fix i686-linux --enable-targets=all

["H.J. Lu" <hjl@lucon.org>]

On Mon, Aug 06, 2007 at 09:51:41AM -0400, Daniel Jacobowitz wrote:
> On Mon, Aug 06, 2007 at 06:41:28AM -0700, H.J. Lu wrote:
> > It is the part of
> > 
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31868
> > 
> > and a complete patch is posted at
> > 
> > http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00563.html
> > 
> > Could someone please review it?
> 
> I see.  I don't think your patch actually handles this case; you set
> CRTSTUFF_T_FLAGS in t-crtstuff64, but i386/t-crtstuff will be included
> afterwards, and that will set it again.  That's why I did it more

Could you tell me where i386/t-crtstuff is included after
i386/t-crtstuff64? I must have missed it.

> centrally.  The problem is the same for any target that forces
> creation of .eh_frame; my patch won't affect i386-linux crtend.o even
> though it changes the compile flags there.

-fno-asynchronous-unwind-tables is turned off for i386 by default.
That is why i386's crtend.o is OK. Turning it off explicitly should
be OK. I have been using it for 3 months.

> 
> Also, I think += is preferred.

My patch is supposed to set CRTSTUFF_T_CFLAGS only once. += isn't
very useful.


H.J.