From: Daniel Jacobowitz <drow@false.org>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Fix i686-linux --enable-targets=all
Date: Mon, 06 Aug 2007 16:11:00 -0000 [thread overview]
Message-ID: <20070806161138.GA5719@caradoc.them.org> (raw)
In-Reply-To: <46B746BD.4030405@gnu.org>
On Mon, Aug 06, 2007 at 06:05:17PM +0200, Paolo Bonzini wrote:
>
> > -CRTSTUFF_T_CFLAGS_S = -fPIC
> > +CRTSTUFF_T_CFLAGS_S = $(CRTSTUFF_T_CFLAGS) -fPIC
>
> This
>
> CRTSTUFF_T_CFLAGS_S = $(CRTSTUFF_T_CFLAGS_S) -fPIC
>
> wouldn't actually work at all (infinite recursion). :-)
I made the same mistake reading it. CRTSTUFF_T_CFLAGS on the RHS
should be defined independently of CRTSTUFF_T_CFLAGS_S on the right.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-06 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 13:37 Daniel Jacobowitz
2007-08-06 13:39 ` Andrew Pinski
2007-08-06 13:41 ` H.J. Lu
2007-08-06 13:51 ` Daniel Jacobowitz
2007-08-06 14:13 ` H.J. Lu
2007-08-06 14:24 ` Daniel Jacobowitz
2007-08-06 14:56 ` H.J. Lu
2007-08-06 15:07 ` Daniel Jacobowitz
2007-08-06 16:05 ` Paolo Bonzini
2007-08-06 16:11 ` Daniel Jacobowitz [this message]
2007-08-06 16:29 ` H.J. Lu
2007-08-06 18:34 Paolo Bonzini
2007-08-06 19:53 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806161138.GA5719@caradoc.them.org \
--to=drow@false.org \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).