From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19347 invoked by alias); 7 Aug 2007 08:29:44 -0000 Received: (qmail 19282 invoked by uid 22791); 7 Aug 2007 08:29:43 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Aug 2007 08:29:39 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l778TamA218886 for ; Tue, 7 Aug 2007 08:29:36 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l778TZ3N1724606 for ; Tue, 7 Aug 2007 10:29:35 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l778TWSh003133 for ; Tue, 7 Aug 2007 10:29:32 +0200 Received: from blc4eb430604175.ibm.com (dyn-9-152-216-52.boeblingen.de.ibm.com [9.152.216.52]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l778TWEj003127; Tue, 7 Aug 2007 10:29:32 +0200 Received: by blc4eb430604175.ibm.com (sSMTP sendmail emulation); Tue, 7 Aug 2007 10:28:31 +0200 Date: Tue, 07 Aug 2007 08:29:00 -0000 From: Andreas Krebbel To: Rask Ingemann Lambertsen Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] lower-subreg: Decompose multiword shifts Message-ID: <20070807082831.GA22687@blc4eb430604175.ibm.com> References: <20070802153434.GA24953@blc4eb430604175.ibm.com> <20070802185148.GJ25795@sygehus.dk> <20070802192140.GA32685@de.ibm.com> <20070807014133.GX25795@sygehus.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070807014133.GX25795@sygehus.dk> User-Agent: Mutt/1.4.1i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00416.txt.bz2 Hello, > For starters, some targets have 16 bits wide int so your testcase will > fail there with excess errors. Since your shift counts and constants in the > testcase assume 32 bits for u32 and 64 bits for u64, you should use the > stdint.h types because they work on all targets. But I don't want to test 32 shifts on *all* targets. I just wanted it on targets where a register is 32 bits wide. And yes I completely forgot to limit the testcase to those. I'll restrict the testcase to ilp32 targets. Although this doesn't mean that a register is always 32 bit it at least disables the testcase for targets where it would fail. > > considering that I need something as wide as register and something else with twice the size. > > Somewhat surpricingly, a fairly common 64-bit target such as x86_64 has a > long long with a width of only 64 bits rather than the expected 128 bits. If > you scanned the RTL dumps to check that the decomposition happened, x86_64 > would fail the testcase. Yes I know and since it isn't easy to express a 128 bit integer data type the testcase should be disabled for 64bit targets as well. Bye, -Andreas-