public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Zdenek Dvorak <rakdver@kam.mff.cuni.cz>
To: Diego Novillo <dnovillo@google.com>
Cc: Dorit Nuzman <DORIT@il.ibm.com>, Ira Rosen <IRAR@il.ibm.com>,
		gcc-patches@gnu.org, dberlin@dberlin.org, dvorakz@suse.cz
Subject: Re: [patch] Remove redundant calls to copy_virtual_operands
Date: Wed, 08 Aug 2007 09:41:00 -0000	[thread overview]
Message-ID: <20070808094101.GA32541@kam.mff.cuni.cz> (raw)
In-Reply-To: <46B8723C.60007@google.com>

Hello,

> On 8/7/07 9:07 AM, Dorit Nuzman wrote:
> 
> > it looks ok to me, but it would be much better if one of the aliasing/vops
> > experts took a look
> 
> Yeah, it is OK.  As I mentioned earlier, I would only suggest doing
> compile-time tests.  Though if this fixes ICEs, then it's really better
> even if a tad slower.  Leaving this to update_ssa is certainly easier to
> maintain.

on the other hand, the fact that there are ICEs shows that there is some
problem in setting the alias information for the new statements in
vectorizer -- if this were correct, the virtual operands would be
exactly the same as the ones of the original statement; so although I
agree that leaving things to update_ssa is easier to maintain (although
possibly much slower), it would be nice if someone could check what does
the alias information updating code in vectorizer get wrong,

Zdenek

  parent reply	other threads:[~2007-08-08  9:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07 12:10 Ira Rosen
2007-08-07 13:06 ` Dorit Nuzman
2007-08-07 13:23   ` Diego Novillo
2007-08-08  8:02     ` Ira Rosen
2007-08-08 12:06       ` Diego Novillo
2007-08-08  9:41     ` Zdenek Dvorak [this message]
2007-08-08 11:04       ` Ira Rosen
2007-08-12 19:40         ` Zdenek Dvorak
2007-08-07 13:22 ` Diego Novillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070808094101.GA32541@kam.mff.cuni.cz \
    --to=rakdver@kam.mff.cuni.cz \
    --cc=DORIT@il.ibm.com \
    --cc=IRAR@il.ibm.com \
    --cc=dberlin@dberlin.org \
    --cc=dnovillo@google.com \
    --cc=dvorakz@suse.cz \
    --cc=gcc-patches@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).