From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11932 invoked by alias); 8 Aug 2007 10:18:36 -0000 Received: (qmail 11814 invoked by uid 22791); 8 Aug 2007 10:18:36 -0000 X-Spam-Check-By: sourceware.org Received: from nikam-dmz.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Aug 2007 10:18:34 +0000 Received: from localhost (campfire.ms.mff.cuni.cz [195.113.18.99]) by nikam.ms.mff.cuni.cz (Postfix) with ESMTP id BF61C5B87E; Wed, 8 Aug 2007 12:18:31 +0200 (CEST) Received: by localhost (Postfix, from userid 29025) id C0B30E34AB; Wed, 8 Aug 2007 12:18:31 +0200 (CEST) Date: Wed, 08 Aug 2007 10:18:00 -0000 From: Zdenek Dvorak To: Andrew Pinski Cc: "Andrew_Pinski@playstation.sony.com" , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix IV-opts so it no longer produces MEM[index:] Message-ID: <20070808101831.GA5205@kam.mff.cuni.cz> References: <20070801095236.GA13479@kam.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00495.txt.bz2 Hello, > On 8/1/07, Andrew_Pinski@playstation.sony.com > > No, this is why we are getting MEM[index:] as generic_type_for for pointer > > types is unsigned_type_for and unsigned_type_for returns the same size > > integer as the pointer which is not what we want here really. Maybe we > > should return the pointer to void type instead? > > Here is a new patch with an additional comment on why not converting > to type is necessary/correct. It also takes into account your comment > about create_iv. > > OK? Bootstrapped and tested on i386-apple-darwin8.10 with no regressions. the tree-ssa-loop-manip.c and tree-ssa-loop-ivopts.c pieces are OK. I think you did not fix the tree-affine.c part? Zdenek