public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <burnus@net-b.de>
Cc: Janne Blomqvist <blomqvist.janne@gmail.com>,
	        Asher Langton <langton2@llnl.gov>,
	fortran@gcc.gnu.org,         gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, fortran] Add -frecursive and fix local array handling  with -fopenmp
Date: Thu, 16 Aug 2007 09:07:00 -0000	[thread overview]
Message-ID: <20070816090722.GW2063@devserv.devel.redhat.com> (raw)
In-Reply-To: <46C40FEC.6060101@net-b.de>

On Thu, Aug 16, 2007 at 10:50:52AM +0200, Tobias Burnus wrote:
> Note that you only see "weird things" if you have either parallel code
> (-fopenmp) which is fixed by Asher's patch or whether you are using
> recurse code without specifying RESCURSIVE, which is invalid Fortran.
> 
> 
> Regarding Asher's patch, I think it is OK as it.

I don't like that, overriding explicit -fmax-stack-var-size=XXX by -fopenmp
sounds like a very bad idea to me.
-fopenmp certainly can change the default, when -fmax-stack-var-size=XXX
isn't explicitly used, from 32K to -1, but if the user requests particular
cutoff we should honor that.

Silently changing RLIMIT_STACK in libgfortran is IMHO not a good idea,
for OpenMP programs that will not help, because at that point libpthread
is already initialized and thread stacks will have different default size
already anyway, and when Fortran programs spawn other programs it would
cause bad havoc (e.g. recent make decided to do this silly thing and
suddenly several programs started weirdly misbehaving when run from
Makefile as opposed to when run without make - we had to change make
to make sure stack limit is restored before execve).

	Jakub

  reply	other threads:[~2007-08-16  9:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-15 19:58 Asher Langton
2007-08-15 21:53 ` Janne Blomqvist
2007-08-16  8:51   ` Tobias Burnus
2007-08-16  9:07     ` Jakub Jelinek [this message]
2007-08-16 18:34       ` Asher Langton
2007-08-16 18:24     ` Asher Langton
2007-08-17  7:53       ` Tobias Burnus
2007-08-17 18:34         ` Asher Langton
2007-08-16 11:48   ` François-Xavier Coudert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070816090722.GW2063@devserv.devel.redhat.com \
    --to=jakub@redhat.com \
    --cc=blomqvist.janne@gmail.com \
    --cc=burnus@net-b.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=langton2@llnl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).