From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15092 invoked by alias); 13 Sep 2007 01:15:08 -0000 Received: (qmail 15081 invoked by uid 22791); 13 Sep 2007 01:15:07 -0000 X-Spam-Check-By: sourceware.org Received: from hiauly1.hia.nrc.ca (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 13 Sep 2007 01:15:02 +0000 Received: from hiauly1.hia.nrc.ca (hiauly1.hia.nrc.ca [127.0.0.1] (may be forged)) by hiauly1.hia.nrc.ca (8.13.7/8.13.7) with ESMTP id l8D1EuNI017929; Wed, 12 Sep 2007 21:14:57 -0400 (EDT) Received: (from dave@localhost) by hiauly1.hia.nrc.ca (8.13.7/8.13.7/Submit) id l8D0m0rR017546; Wed, 12 Sep 2007 20:48:00 -0400 (EDT) Message-Id: <200709130048.l8D0m0rR017546@hiauly1.hia.nrc.ca> Subject: Re: [patch,testsuite] Fix PR testsuite/33153 To: jakub@redhat.com Date: Thu, 13 Sep 2007 02:28:00 -0000 From: "John David Anglin" Cc: gcc-patches@gcc.gnu.org, mark@codesourcery.com In-Reply-To: <20070827082528.GN2063@devserv.devel.redhat.com> from "Jakub Jelinek" at Aug 27, 2007 04:25:28 am X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-09/txt/msg01146.txt.bz2 > > In looking at pr32912-2.c, I noticed that a, b, c, d, e and f are > > not used, so I would like to revise my last patch. > > Both changes look ok to me, the latter is certainly obvious. > For the first you could alternatively try __attribute__((nocommon)), > though I wonder if pa/hpux shouldn't do that automatically for objects > which it can't create as common, perhaps with some warning. I've committed the following to trunk. Mark, this fixes a testsuite regression introduced after the 4.2.1 release. Is this ok for 4.2.2? Regards, Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) 2007-09-12 John David Anglin PR testsuite/33153 * gcc.dg/pr32912-1.c: Add -fno-common to options on hppa*-*-hpux*. * gcc.dg/pr32912-2.c: Delete declaration of a, b, c, d, e and f. Index: gcc.dg/pr32912-1.c =================================================================== --- gcc.dg/pr32912-1.c (revision 128448) +++ gcc.dg/pr32912-1.c (working copy) @@ -1,6 +1,7 @@ /* PR middle-end/32912 */ /* { dg-do run } */ /* { dg-options "-O2 -w" } */ +/* { dg-options "-O2 -w -fno-common" { target hppa*-*-hpux* } } */ extern void abort (void); Index: gcc.dg/pr32912-2.c =================================================================== --- gcc.dg/pr32912-2.c (revision 128448) +++ gcc.dg/pr32912-2.c (working copy) @@ -5,8 +5,6 @@ typedef int __m128i __attribute__ ((__vector_size__ (16))); -__m128i a, b, c, d, e, f; - __m128i foo (void) {