From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9178 invoked by alias); 10 Oct 2007 08:46:32 -0000 Received: (qmail 9170 invoked by uid 22791); 10 Oct 2007 08:46:32 -0000 X-Spam-Check-By: sourceware.org Received: from atrey.karlin.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 Oct 2007 08:46:29 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 18E8D23C8CF8; Wed, 10 Oct 2007 10:46:26 +0200 (CEST) Date: Wed, 10 Oct 2007 08:46:00 -0000 From: Jan Hubicka To: Alexandre Oliva Cc: Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: Put scope blocks on a diet Message-ID: <20071010084624.GA19060@atrey.karlin.mff.cuni.cz> References: <20070724180235.GM24519@kam.mff.cuni.cz> <20070806201102.GF4460@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-10/txt/msg00544.txt.bz2 > > I did this, but then I wonder... How come the differences in decl > uids arise from inlining of removed variables, if the patch was > supposed to take effect only after inlining? > > As it turns out, looking at the code, I get the impression that > cfun->after_inline determines whether the function was inlined into, cfun->after_inline is set after fixup_cfg that removes extra edges from cfg otherwise needed by inliner, so we really ought not to inline that function after that point. On mainline fixup_cfg is executed after apply_inline, so it should be safe. Honza > rather than whether it has already been inlined into every point it > would be throughout the current compilation. Is this not so? > > If it is, then the test is meaningless. The problem arises when we > change the declarations in a function's logical blocks and then inline > into others. > > What am I missing? > > -- > Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/ > FSF Latin America Board Member http://www.fsfla.org/ > Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org} > Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}