public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: bkoz@redhat.com
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Your re/move of ext/hash_map causes a regression
Date: Thu, 18 Oct 2007 19:10:00 -0000	[thread overview]
Message-ID: <200710181759.l9IHxYaP018976@ignucius.se.axis.com> (raw)
In-Reply-To: <20071011163745.34e0ae98@concorde.artheist.org> (message from 	Benjamin Kosnik on Thu, 11 Oct 2007 16:37:45 -0500)

> Date: Thu, 11 Oct 2007 16:37:45 -0500
> From: Benjamin Kosnik <bkoz@redhat.com>

> Converts existing uses of hash containers to TR1 containers, as the
> first step in deprecating ext/hash_map, ext/hash_set.

When you (re)moved ext/hash_map, you forgot to adjust the g++
testsuite.  I see a regression for cris-elf (likely everywhere)
between 129434 and 129442:

Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/g++.old-deja/old-deja.exp ...
FAIL: g++.old-deja/g++.robertl/eb130.C (test for excess errors)

with g++.log:

/tmp/hpautotest-gcc1/gcc/gcc/testsuite/g++.old-deja/g++.robertl/eb130.C:9: error: ext/hash_set: No such file or directory
/tmp/hpautotest-gcc1/gcc/gcc/testsuite/g++.old-deja/g++.robertl/eb130.C:10: error: '__gnu_cxx' has not been declared
/tmp/hpautotest-gcc1/gcc/gcc/testsuite/g++.old-deja/g++.robertl/eb130.C:10: error: expected constructor, destructor, or type conversion before '<' token

The non-comment parts of eb130 are short enough to include:

#include <ext/hash_set>
__gnu_cxx::hash_set<int> foo;

Dunno what's the right fix here; <backward/hash_set> maybe.

brgds, H-P

  reply	other threads:[~2007-10-18 17:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 21:37 [v3] use tr1 unordered containers instead of ext hash containers Benjamin Kosnik
2007-10-18 19:10 ` Hans-Peter Nilsson [this message]
2007-10-18 21:42   ` Your re/move of ext/hash_map causes a regression Benjamin Kosnik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710181759.l9IHxYaP018976@ignucius.se.axis.com \
    --to=hans-peter.nilsson@axis.com \
    --cc=bkoz@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).