public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje@watson.ibm.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH,committed] g++.dg testsuite cleanups
Date: Sun, 04 Nov 2007 16:39:00 -0000	[thread overview]
Message-ID: <200711041639.lA4GdLh6037106@makai.watson.ibm.com> (raw)

	The appended patch fixes some g++.dg failures on AIX.

dg-require-visibility was missing an argument, causing it to be run on
targets that do not support visibility.

java-1.C references a symbol that includes a dollar sign, but AIX does not
allow dollar signs in identifiers.

Bootstrapped and regression tested on powerpc-ibm-aix5.3.0.0.  Committed
as obvious.

David


	* g++.dg/cpp/_Pragma1.C: Disable on AIX.
	* g++.dg/ext/visibility/namespace2.C: Add argument to
	dg-require-visibility.
	* g++.dg/ext/java-1.C: Disable on AIX.

Index: cpp/_Pragma1.C
===================================================================
--- cpp/_Pragma1.C	(revision 129879)
+++ cpp/_Pragma1.C	(working copy)
@@ -2,7 +2,7 @@
 // This is supposed to succeed only if
 // the target defines HANDLE_PRAGMA_PACK_PUSH_POP 
 // and doesn't define HANDLE_PRAGMA_PACK_WITH_EXPANSION.
-// { dg-do compile { target { ! { *-*-solaris2* fido-*-* m68k-*-* sh*-[us]*-elf } } } }
+// { dg-do compile { target { ! { powerpc-ibm-aix* *-*-solaris2* fido-*-* m68k-*-* sh*-[us]*-elf } } } }
 
 #define push bar
 #define foo _Pragma ("pack(push)")
Index: ext/visibility/namespace2.C
===================================================================
--- ext/visibility/namespace2.C	(revision 129879)
+++ ext/visibility/namespace2.C	(working copy)
@@ -1,6 +1,6 @@
 // PR c++/32470
 
-// { dg-require-visibility }
+// { dg-require-visibility "" }
 // { dg-options "-fvisibility=hidden" }
 // { dg-final { scan-hidden "_ZN4Test4testEv" } }
 
Index: ext/java-1.C
===================================================================
--- ext/java-1.C	(revision 129879)
+++ ext/java-1.C	(working copy)
@@ -1,4 +1,4 @@
-// { dg-do compile }
+// { dg-do compile { target { ! { powerpc-ibm-aix* } } } }
 // { dg-options "" }
 // Test extern "java" and some throwing of the objects.
 

                 reply	other threads:[~2007-11-04 16:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711041639.lA4GdLh6037106@makai.watson.ibm.com \
    --to=dje@watson.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).