From: "Michael Meissner" <michael.meissner@amd.com>
To: "Andreas Krebbel" <Andreas.Krebbel@de.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PING] Target hook for rewriting inline asm constraints
Date: Tue, 06 Nov 2007 18:20:00 -0000 [thread overview]
Message-ID: <20071106181838.GA31748@mmeissner-gold.amd.com> (raw)
In-Reply-To: <20071030115424.GA6864@homer.boeblingen.de.ibm.com>
On Tue, Oct 30, 2007 at 12:54:24PM +0100, Andreas Krebbel wrote:
> Hello,
>
> could a C front end and/or middle end maintainer please have a look at
> this one:
>
> http://gcc.gnu.org/ml/gcc-patches/2007-10/msg01407.html
I'm catching up on my backlog.
Here are the nit-picky comments about the change:
First, fixed size string arrays (result and tmp in c_parser_asm_operands) is
not a good idea.
Second, using repeated strlen calls to grow the string is also not a good idea
(in c_parser_asm_operand).
Third the local variables for c_parser_asm_operand should be moved into the
outer scope.
Fourth, you added the include file tm_p.h to the includes of c-parser.c, but I
did not see a corresponding modification to Makefile.in for this dependency.
Now, getting on the broader scope issues about the patch, I can sympathize with
the desire, but I think this is really opening up a can of worms if we let the
back end rewrite asm constraints like this. I'm also not sure I understand
what the exact problem is. I would imagine if you have address modes that are
allowed in some cases, but not others, this is better expressed in
GO_IF_MODE_DEPENDENT_ADDRESS instead of GO_IF_LEGITIMATE_ADDRESS.
--
Michael Meissner, AMD
90 Central Street, MS 83-29, Boxborough, MA, 01719, USA
michael.meissner@amd.com
next prev parent reply other threads:[~2007-11-06 18:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 12:54 Andreas Krebbel
2007-10-31 16:31 ` Tom Tromey
2007-10-31 16:43 ` Richard Guenther
2007-10-31 18:55 ` Andreas Krebbel
2007-10-31 19:13 ` Richard Guenther
2007-10-31 20:40 ` Andreas Krebbel
2007-11-04 23:05 ` Richard Sandiford
2007-11-05 9:25 ` Andreas Krebbel
2007-11-05 9:43 ` Richard Sandiford
2007-11-05 10:32 ` Andreas Krebbel
2007-11-05 11:02 ` Richard Sandiford
2007-11-05 13:42 ` Andreas Krebbel
2007-11-06 22:00 ` Richard Sandiford
2007-11-07 11:55 ` Andreas Krebbel
2007-10-31 17:22 ` Andreas Krebbel
2007-10-31 17:56 ` Tom Tromey
2007-11-06 18:20 ` Michael Meissner [this message]
2007-11-07 9:10 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106181838.GA31748@mmeissner-gold.amd.com \
--to=michael.meissner@amd.com \
--cc=Andreas.Krebbel@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).