[objc] testsuite set of -I

[objc] testsuite set of -I

[Aldy Hernandez]

Hi folks.

Is there any reason why we set -I only if we have built libobjc?  This
doesn't make sense.  This just means we won't be able to test compile
only tests (with include files) unless libobjc is built.

I'm running into this while building tuples.  I have a working objc
compiler, but not libobjc because our tuples->RTL pass is not working
yet, so I can't test even compile tests without this patch.

Is this OK for mainline after it re-opens?

Aldy

=== obj-c++.exp
==================================================================
--- obj-c++.exp	(revision 130048)
+++ obj-c++.exp	(local)
@@ -317,10 +317,8 @@
 	}
     }
 
-    if { $libobjc_dir != "" } {
-	set objc_include_dir "${srcdir}/../../libobjc"
-	lappend options "additional_flags=-I${objc_include_dir}"
-    }
+    set objc_include_dir "${srcdir}/../../libobjc"
+    lappend options "additional_flags=-I${objc_include_dir}"
 
     lappend options "additional_flags=[libio_include_flags]"
     lappend options "compiler=$OBJCXX_UNDER_TEST";
=== objc.exp
==================================================================
--- objc.exp	(revision 130048)
+++ objc.exp	(local)
@@ -179,9 +179,9 @@
 	     [lookfor_file ${objcpath} libobjc/.libs/libobjc-gnu.${shlib_ext}]
 	}
     }
+    set objc_include_dir "${srcdir}/../../libobjc"
+    lappend options "additional_flags=-I${objc_include_dir}"
     if { $libobjc_dir != "" } {
-	set objc_include_dir "${srcdir}/../../libobjc"
-	lappend options "additional_flags=-I${objc_include_dir}"
 	set libobjc_dir [file dirname ${libobjc_dir}]
 	set objc_link_flags "-L${libobjc_dir}"
 	lappend options "additional_flags=${objc_link_flags}"

Re: [objc] testsuite set of -I

[Joseph S. Myers]

On Sat, 10 Nov 2007, Aldy Hernandez wrote:

> Is there any reason why we set -I only if we have built libobjc?  This
> doesn't make sense.  This just means we won't be able to test compile

It does make sense - if you're testing an installed toolchain you should 
use the installed objc headers installed with that toolchain and not those 
in the source tree, if not testing an installed toolchain then you are 
expected to have a full build tree.

Include and library paths for installed testing should be similar to those 
used by real toolchain users.  Real users won't have -I paths pointing to 
the libobjc source directory, so neither should installed toolchain 
testing.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [objc] testsuite set of -I

[Aldy Hernandez]

On Sun, Nov 11, 2007 at 12:44:28AM +0000, Joseph S. Myers wrote:
> On Sat, 10 Nov 2007, Aldy Hernandez wrote:
> 
> > Is there any reason why we set -I only if we have built libobjc?  This
> > doesn't make sense.  This just means we won't be able to test compile
> 
> It does make sense - if you're testing an installed toolchain you should 
> use the installed objc headers installed with that toolchain and not those 
> in the source tree, if not testing an installed toolchain then you are 
> expected to have a full build tree.

Actually, this makes perfect sense.  Thanks for your explanation.

Aldy