From: Zdenek Dvorak <rakdver@kam.mff.cuni.cz>
To: Sebastian Pop <sebpop@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fix ICE in loop unrolling
Date: Wed, 14 Nov 2007 19:34:00 -0000 [thread overview]
Message-ID: <20071114170208.GA24049@kam.mff.cuni.cz> (raw)
In-Reply-To: <cb9d34b20711140815u732f4cf9hafaedca92e4c38bd@mail.gmail.com>
Hi,
> Here is an update of the patch with your suggestion also implemented.
> Regstrapped on amd64-linux. Okay for trunk?
this is OK. It would be also nice to replace this:
> + cond = last_stmt (exit->src);
> + COND_EXPR_COND (cond) = (exit->flags & EDGE_TRUE_VALUE) ? boolean_true_node
> + : boolean_false_node;
> + update_stmt (cond);
> update_ssa (TODO_update_ssa);
by removing the non-exit edge. That will completely remove the loop,
though, and I am not sure whether the code using this function would to
handle this correcly (we definitely do not want to do that in stage 3,
unless there turns out to be some PR requiring it).
Zdenek
prev parent reply other threads:[~2007-11-14 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 0:35 Sebastian Pop
2007-11-08 4:41 ` Zdenek Dvorak
2007-11-14 18:27 ` Sebastian Pop
2007-11-14 19:34 ` Zdenek Dvorak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114170208.GA24049@kam.mff.cuni.cz \
--to=rakdver@kam.mff.cuni.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=sebpop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).