From: Eric Botcazou <ebotcazou@libertysurf.fr>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RFA:] Split REG_LABEL into REG_LABEL_TARGET and REG_LABEL_OPERAND
Date: Sat, 24 Nov 2007 21:12:00 -0000 [thread overview]
Message-ID: <200711241745.39686.ebotcazou@libertysurf.fr> (raw)
In-Reply-To: <200711132331.lADNVEcY001847@ignucius.se.axis.com>
[Sorry for the delay too. :-)]
> This code rarely hits these days (post DF), if ever. I thought it was
> just about necessary for targets with branch-target registers for
> conditional branches like sh64 (unique in this aspect AFAICT) but that
> target doesn't split the branch-target-register-load from the branch
> until register allocation and by that time, JUMP_LABEL is safely set.
> I instrumented the code with a gcc_unreachable, and this code only
> hits for gcc.c-torture/compile/920501-7.c (for most targets). If you
> prefer, I can remove this code. The situation may of course change if
> more passes start calling mark_all_labels.
OK, let's keep it then.
> * rtlanal.c (label_is_jump_target_p): Return true for a matching
> REG_LABEL_TARGET.
> * reorg.c (fill_slots_from_thread): Correct last change to use
> NULL_RTX, not NULL. Outside of REG_NOTES loop, increase and
> decrease LABEL_NUSES for JUMP_LABEL (trial), not XEXP (note, 0).
OK for mainline, thanks for following up on this.
--
Eric Botcazou
next prev parent reply other threads:[~2007-11-24 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-30 20:54 Hans-Peter Nilsson
2006-01-30 21:31 ` Hans-Peter Nilsson
2006-01-30 22:18 ` Hans-Peter Nilsson
2006-02-25 0:05 ` Geoffrey Keating
2007-09-04 5:12 ` [RFA:] " Hans-Peter Nilsson
2007-09-09 7:13 ` Hans-Peter Nilsson
2007-09-09 10:47 ` Eric Botcazou
2007-09-13 3:17 ` Hans-Peter Nilsson
2007-09-13 13:15 ` Eric Botcazou
2007-11-14 0:24 ` Hans-Peter Nilsson
2007-11-24 21:12 ` Eric Botcazou [this message]
2007-11-15 12:14 ` Hans-Peter Nilsson
2007-11-24 21:16 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711241745.39686.ebotcazou@libertysurf.fr \
--to=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).