From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30109 invoked by alias); 24 Nov 2007 16:45:53 -0000 Received: (qmail 30101 invoked by uid 22791); 24 Nov 2007 16:45:53 -0000 X-Spam-Check-By: sourceware.org Received: from mx-out.libertysurf.net (HELO mail.libertysurf.net) (213.36.80.91) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 24 Nov 2007 16:45:47 +0000 Received: from [192.168.1.3] (83.156.58.72) by mail.libertysurf.net (7.3.118.8) id 470CEC870070C335; Sat, 24 Nov 2007 18:46:47 +0100 From: Eric Botcazou To: Hans-Peter Nilsson Subject: Re: [RFA:] Split REG_LABEL into REG_LABEL_TARGET and REG_LABEL_OPERAND Date: Sat, 24 Nov 2007 21:12:00 -0000 User-Agent: KMail/1.7.1 Cc: gcc-patches@gcc.gnu.org References: <200711132331.lADNVEcY001847@ignucius.se.axis.com> In-Reply-To: <200711132331.lADNVEcY001847@ignucius.se.axis.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200711241745.39686.ebotcazou@libertysurf.fr> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-11/txt/msg01295.txt.bz2 [Sorry for the delay too. :-)] > This code rarely hits these days (post DF), if ever. I thought it was > just about necessary for targets with branch-target registers for > conditional branches like sh64 (unique in this aspect AFAICT) but that > target doesn't split the branch-target-register-load from the branch > until register allocation and by that time, JUMP_LABEL is safely set. > I instrumented the code with a gcc_unreachable, and this code only > hits for gcc.c-torture/compile/920501-7.c (for most targets). If you > prefer, I can remove this code. The situation may of course change if > more passes start calling mark_all_labels. OK, let's keep it then. > * rtlanal.c (label_is_jump_target_p): Return true for a matching > REG_LABEL_TARGET. > * reorg.c (fill_slots_from_thread): Correct last change to use > NULL_RTX, not NULL. Outside of REG_NOTES loop, increase and > decrease LABEL_NUSES for JUMP_LABEL (trial), not XEXP (note, 0). OK for mainline, thanks for following up on this. -- Eric Botcazou