From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-208252-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 16774 invoked by alias); 25 Nov 2007 15:04:36 -0000
Received: (qmail 16757 invoked by uid 22791); 25 Nov 2007 15:04:35 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 25 Nov 2007 15:04:29 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lAPF4R2o003238; 	Sun, 25 Nov 2007 10:04:27 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAPF4QbV028382; 	Sun, 25 Nov 2007 10:04:26 -0500
Received: from pantani.quesejoda.com (sebastian-int.corp.redhat.com [172.16.52.221]) 	by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAPF4PGD023482; 	Sun, 25 Nov 2007 10:04:26 -0500
Received: by pantani.quesejoda.com (Postfix, from userid 500) 	id 3B8D711A0347; Sun, 25 Nov 2007 11:04:25 -0400 (AST)
Date: Sun, 25 Nov 2007 21:32:00 -0000
From: Aldy Hernandez <aldyh@redhat.com>
To: Tobias Burnus <burnus@net-b.de>, jakub@redhat.com
Cc: Jack Howarth <howarth@bromo.msbb.uc.edu>,         Richard Guenther <richard.guenther@gmail.com>, fortran@gcc.gnu.org,         Andrew Pinski <pinskia@gmail.com>, Diego Novillo <dnovillo@google.com>,         gcc-patches@gcc.gnu.org
Subject: Re: libgomp failure (was: Re: [FORTRAN mainline] dereference 	POINTER_PLUS_EXPR check)
Message-ID: <20071125150424.GA24133@redhat.com>
References: <20071121215235.GA11077@redhat.com> <84fc9c000711211357w7a2587d2n663dd561845e4e1c@mail.gmail.com> <20071121225800.GA5508@redhat.com> <84fc9c000711211525h37554477yf567a8265f09d59@mail.gmail.com> <20071122005837.GA7171@redhat.com> <de8d50360711211709k61f0f066lf483e97645564df2@mail.gmail.com> <20071122172301.GA17740@redhat.com> <84fc9c000711220948p74bf7bb8he63f95baf9ba38f1@mail.gmail.com> <20071123002727.GA16608@redhat.com> <47484E4F.9090801@net-b.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47484E4F.9090801@net-b.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-11/txt/msg01327.txt.bz2

Hi folks.  Hi Jakub.

I've found what the cause of the problem reported below, but I am unsure
as to how to fix it.  Perhaps Jakub can shed some light.

With the patch below, the type of the P_P_E is now:

    type <reference_type 0x2aaaaab90240
        type <array_type 0x2aaaaab90180 type ...

gfc_omp_privatize_by_reference is now being called with a temporary of
the above type.  This function returns TRUE for any REFERENCE_TYPE.
Without the patch, it obviously returned pchar_type_node which returned
false.

My naive solution is to use PTR_TYPE_NODE instead of TREE_TYPE(dest) in
my original patch, but Richard G had commented that we should ideally be
type-exact in the expression tree.  Do folks care if I make this
PTR_TYPE_NODE, or is a fix in gfc_omp_privatize_by_reference in order?

Thanks.
Aldy

> This patch seems to cause a lot of libgomp regressions.
> See: http://gcc.gnu.org/ml/fortran/2007-11/msg00209.html
...
> +       * trans-expr.c (gfc_trans_string_copy): Use "void *" when building a
> +       memset.
> > 	* trans-expr.c (gfc_trans_string_copy): Use "void *" when building a
> > 	memset.
> >  
> > --- trans-expr.c	(revision 130355)
> > +++ trans-expr.c	(local)
> > @@ -2701,7 +2701,7 @@ gfc_trans_string_copy (stmtblock_t * blo
> >    tmp3 = build_call_expr (built_in_decls[BUILT_IN_MEMMOVE],
> >  			  3, dest, src, slen);
> >  
> > -  tmp4 = fold_build2 (POINTER_PLUS_EXPR, pchar_type_node, dest,
> > +  tmp4 = fold_build2 (POINTER_PLUS_EXPR, TREE_TYPE (dest), dest,
> >  		      fold_convert (sizetype, slen));
> >    tmp4 = build_call_expr (built_in_decls[BUILT_IN_MEMSET], 3,