Re: [PATCH] Don't hardcode the makefile name in config-ml.in

[Ralf Wildenhues <Ralf.Wildenhues@gmx.de>]

* Paolo Bonzini wrote on Mon, Nov 26, 2007 at 11:48:22AM CET:
>
>> Please try the first patch in
>> <http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01183.html>.
>
> The third patch there is okay.

Thanks.  I need someone to apply it for me (to GCC and src).

> Now on to the first.  First of all, my apologies for approving the wrong 
> patch.  I hadn't realized that the modified code was inside a "cat << 
> \EOF".
>
> If I understand correctly, the ${Makefile} in
>
> 	  for dir in ${Makefile} $(MULTIDIRS); do \
>
> is just a way to avoid an error if MULTIDIRS is empty but [ -z 
> "$(MULTIDIRS)" ] does not get it?

OK, but then I would do this:
  for dir in : $(MULTIDIRS); do \
    test $$dir != : || continue; \

If you like, I can submit a patch for this tonight.

> If this is the case, I would prefer to 
> have something like
>
>         set fnord $(MULTIDIRS); shift; \
>         lib=`${PWD_COMMAND} | sed -e 's,^.*/\([^/][^/]*\)$$,\1,'`; \
>         for dir; do \
[...]
>
> Ralf, portability-wise, what do you think?

Some ancient shell out there does not grok `for dir; do'
but only `for dir
          do'

(i.e., a newline works, but semi-colon doesn't).

Cheers,
Ralf