From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-208306-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 18796 invoked by alias); 26 Nov 2007 11:57:00 -0000
Received: (qmail 18784 invoked by uid 22791); 26 Nov 2007 11:57:00 -0000
X-Spam-Check-By: sourceware.org
Received: from merkur.ins.uni-bonn.de (HELO merkur.ins.uni-bonn.de) (131.220.223.13)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 26 Nov 2007 11:56:54 +0000
Received: from ins.uni-bonn.de (gibraltar [192.168.193.254]) 	by merkur.ins.uni-bonn.de (Postfix) with ESMTP id CA90840000C5C; 	Mon, 26 Nov 2007 12:56:51 +0100 (CET)
Date: Mon, 26 Nov 2007 15:04:00 -0000
From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Hans-Peter Nilsson <hp@bitrange.com>, Thiemo Seufer <ths@networkno.de>, 	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Don't hardcode the makefile name in config-ml.in
Message-ID: <20071126115650.GB15662@ins.uni-bonn.de>
Mail-Followup-To: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>, 	Paolo Bonzini <bonzini@gnu.org>, 	Hans-Peter Nilsson <hp@bitrange.com>, 	Thiemo Seufer <ths@networkno.de>, 	GCC Patches <gcc-patches@gcc.gnu.org>
References: <20071119005206.GC11996@networkno.de> <20071125193619.F86858@dair.pair.com> <20071126092650.GA15889@ins.uni-bonn.de> <474AA476.7020605@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <474AA476.7020605@gnu.org>
User-Agent: Mutt/1.5.17 (2007-11-13)
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-11/txt/msg01381.txt.bz2

* Paolo Bonzini wrote on Mon, Nov 26, 2007 at 11:48:22AM CET:
>
>> Please try the first patch in
>> <http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01183.html>.
>
> The third patch there is okay.

Thanks.  I need someone to apply it for me (to GCC and src).

> Now on to the first.  First of all, my apologies for approving the wrong 
> patch.  I hadn't realized that the modified code was inside a "cat << 
> \EOF".
>
> If I understand correctly, the ${Makefile} in
>
> 	  for dir in ${Makefile} $(MULTIDIRS); do \
>
> is just a way to avoid an error if MULTIDIRS is empty but [ -z 
> "$(MULTIDIRS)" ] does not get it?

OK, but then I would do this:
  for dir in : $(MULTIDIRS); do \
    test $$dir != : || continue; \

If you like, I can submit a patch for this tonight.

> If this is the case, I would prefer to 
> have something like
>
>         set fnord $(MULTIDIRS); shift; \
>         lib=`${PWD_COMMAND} | sed -e 's,^.*/\([^/][^/]*\)$$,\1,'`; \
>         for dir; do \
[...]
>
> Ralf, portability-wise, what do you think?

Some ancient shell out there does not grok `for dir; do'
but only `for dir
          do'

(i.e., a newline works, but semi-colon doesn't).

Cheers,
Ralf