public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rask Ingemann Lambertsen <rask@sygehus.dk>
To: Mark Mitchell <mark@codesourcery.com>,
	        Bernd Schmidt <bernds_cb1@t-online.de>,
	        Jie Zhang <jzhang918@gmail.com>,
	gcc@gcc.gnu.org,         GCC Patches <gcc-patches@gcc.gnu.org>,
	rsandifo@nildram.co.uk,         hp@gcc.gnu.org
Subject: Re: Link tests after GCC_NO_EXECUTABLES
Date: Fri, 30 Nov 2007 09:58:00 -0000	[thread overview]
Message-ID: <20071130022132.GL17368@sygehus.dk> (raw)
In-Reply-To: <877ik0aerh.fsf@firetop.home>

On Thu, Nov 29, 2007 at 10:05:54PM +0000, Richard Sandiford wrote:

> Even though current mainline can build libgfortran, all tests fail for
> simulator testing, and I'm not sure whether you could get it work for
> bare-metal boards or not. 

   It works on arm-unknown-elf, v850-unknown-elf and frv-unknown-elf:
http://gcc.gnu.org/ml/gcc-testresults/2007-11/msg01428.html
http://gcc.gnu.org/ml/gcc-testresults/2007-11/msg01468.html
http://gcc.gnu.org/ml/gcc-testresults/2007-11/msg00427.html

   Some work has been and is being done in this area:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21185

   Hans, you showed gfortran results for cris-elf, but we don't seem to be
building gfortran for the cris?

> It sounds like we've agreed that, if we want
> to support libgfortran on targets like mips*-elf*, we should use
> libstd++-like with_newlib checks there too.

   Likewise for the other target libraries - how many did you test?

   I tried a build of sparc-unknown-elf (which is know to fail link tests)
with "with_newlib" checks around the AC_LIBTOOL_DLOPEN macro in both
libstdc++ and libgfortran. It fails because:

configure:3391: checking whether symbol versioning is supported
configure:3402: error: Link tests are not allowed after GCC_NO_EXECUTABLES.

With this patch I get marginally further:

Index: libgfortran/configure.ac
===================================================================
--- libgfortran/configure.ac    (revision 130442)
+++ libgfortran/configure.ac    (working copy)
@@ -142,12 +142,14 @@
   global: *foo*; bar; local: *;
 };
 EOF
-save_LDFLAGS="$LDFLAGS"
-LDFLAGS="$LDFLAGS -fPIC -shared -Wl,--version-script,./conftest.map"
-AC_TRY_LINK([int foo;],[],[gfortran_use_symver=yes],[gfortran_use_symver=no])
-LDFLAGS="$save_LDFLAGS"
-AC_MSG_RESULT($gfortran_use_symver)
-AM_CONDITIONAL(LIBGFOR_USE_SYMVER, [test "x$gfortran_use_symver" = xyes])
+if test "x${with_newlib}" != "xyes"; then
+  save_LDFLAGS="$LDFLAGS"
+  LDFLAGS="$LDFLAGS -fPIC -shared -Wl,--version-script,./conftest.map"
+  AC_TRY_LINK([int foo;],[],[gfortran_use_symver=yes],[gfortran_use_symver=no])
+  LDFLAGS="$save_LDFLAGS"
+  AC_MSG_RESULT($gfortran_use_symver)
+  AM_CONDITIONAL(LIBGFOR_USE_SYMVER, [test "x$gfortran_use_symver" = xyes])
+fi

 # Find other programs we need.
 AC_CHECK_TOOL(AS, as)
@@ -158,7 +160,9 @@

 # Configure libtool
 #AC_MSG_NOTICE([====== Starting libtool configuration])
-AC_LIBTOOL_DLOPEN
+if test "x${with_newlib}" != "xyes"; then
+  AC_LIBTOOL_DLOPEN
+fi
 AM_PROG_LIBTOOL
 AC_SUBST(enable_shared)
 AC_SUBST(enable_static)

configure:18061: checking for getrusage
configure:18067: error: Link tests are not allowed after GCC_NO_EXECUTABLES.

> Perhaps we should turn target-libgfortran off by default for mips*-elf*.

   No. There is a point in excercising the compiler: Testing. In most cases,
you don't find problems with the compiler until you try to compile something.

> @@ -2410,6 +2368,16 @@ fi
>  
>  # Search for other target-specific linker scripts and such.
>  case "${target}" in
> +  m32c-*-* )
> +    if test -d ${srcdir}/libgloss/m32c; then
> +      # This is for crt0.o
> +      FLAGS_FOR_TARGET=$FLAGS_FOR_TARGET' -B$$r/$(TARGET_SUBDIR)/libgloss/m32c'
> +      # This is for r8c.ld
> +      FLAGS_FOR_TARGET=$FLAGS_FOR_TARGET' -L$$r/$(TARGET_SUBDIR)/libgloss/m32c'
> +      # This is for libnosys.a
> +      FLAGS_FOR_TARGET=$FLAGS_FOR_TARGET' -L$$r/$(TARGET_SUBDIR)/libgloss/libnosys'
> +    fi
> +    ;;
>    mep*)
>      FLAGS_FOR_TARGET="$FLAGS_FOR_TARGET -mlibrary"
>      ;;

   This hunk should be left out. And I would prefer that we don't revert the
patch until everything that builds with the patch also builds without the
patch.

   Additionally, I would prefer we call the option something else than
--with-newlib - suppose there's no newlib for the target. At least the AVR
uses something else.

-- 
Rask Ingemann Lambertsen
Danish law requires addresses in e-mail to be logged and stored for a year

  parent reply	other threads:[~2007-11-30  2:21 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <46EFBCC1.6070200@gmail.com>
     [not found] ` <46EFC383.7020503@t-online.de>
     [not found]   ` <46EFC9E9.7090201@gmail.com>
     [not found]     ` <46EFCEF9.3060304@t-online.de>
     [not found]       ` <46EFCF7A.2080704@gmail.com>
     [not found]         ` <46EFD236.6080907@t-online.de>
     [not found]           ` <46EFDA4D.3070006@gmail.com>
2007-11-27 15:35             ` Bernd Schmidt
2007-11-27 22:17               ` Mark Mitchell
2007-11-27 22:40                 ` Bernd Schmidt
2007-11-27 22:43                   ` Mark Mitchell
2007-11-27 22:58                     ` Bernd Schmidt
2007-11-27 23:17                       ` Mark Mitchell
2007-11-28  0:23                         ` Bernd Schmidt
2007-11-28  0:33                           ` Mark Mitchell
2007-11-28  1:03                             ` Bernd Schmidt
2007-11-28  1:24                               ` Mark Mitchell
2007-11-28  6:34                                 ` Bernd Schmidt
2007-11-28 10:37                                   ` Mark Mitchell
2007-11-28 15:47                                     ` Bernd Schmidt
2007-11-28  8:16                                 ` Joseph S. Myers
2007-11-28 10:01                                   ` Mark Mitchell
2007-11-28 11:37                                     ` Joseph S. Myers
2007-11-28 11:40                                       ` Mark Mitchell
2007-11-28 15:37                                       ` Bernd Schmidt
2007-11-28 13:07                             ` Richard Sandiford
2007-11-28 16:06                               ` Rask Ingemann Lambertsen
2007-11-28 16:59                               ` Daniel Jacobowitz
2007-11-28 18:55                               ` Mark Mitchell
2007-11-28 22:41                                 ` Richard Sandiford
2007-11-28 23:03                                 ` Rask Ingemann Lambertsen
2007-11-29  6:21                                   ` Mark Mitchell
2007-11-30 21:07                                     ` Rask Ingemann Lambertsen
2007-11-30 21:08                                       ` Mark Mitchell
     [not found]                                         ` <20071130211005.GQ17368@sygehus.dk>
2007-12-01  9:48                                           ` Richard Sandiford
2007-12-01 11:53                                             ` Rask Ingemann Lambertsen
2007-12-01 12:03                                               ` Rask Ingemann Lambertsen
2007-12-01 13:37                                                 ` Andreas Schwab
2007-12-01 22:35                                                   ` Rask Ingemann Lambertsen
2007-12-02 21:11                                                     ` Mark Mitchell
2007-12-05 17:22                                                       ` Rask Ingemann Lambertsen
2007-12-06  0:38                                                         ` Mark Mitchell
2007-12-06 17:58                                                           ` Rask Ingemann Lambertsen
2007-12-07  1:37                                                             ` Mark Mitchell
2007-12-07 15:31                                                               ` Rask Ingemann Lambertsen
2007-12-07 18:39                                                                 ` Mark Mitchell
2007-12-07 21:48                                                                   ` Rask Ingemann Lambertsen
2007-12-07 21:57                                                                     ` Mark Mitchell
2007-12-13 22:25                                                                       ` [PATCH v2] " Rask Ingemann Lambertsen
2007-12-30 13:46                                                                         ` Ping " Rask Ingemann Lambertsen
2007-12-30 17:41                                                                           ` Paolo Bonzini
2007-12-07 11:27                                                             ` Richard Sandiford
2007-12-07 15:18                                                               ` Rask Ingemann Lambertsen
2007-12-08 11:25                                                                 ` Richard Sandiford
2007-12-04 14:46                                                     ` Rask Ingemann Lambertsen
2007-12-05  0:10                                                     ` Hans-Peter Nilsson
2007-12-05  0:19                                                       ` Rask Ingemann Lambertsen
2007-12-05  0:46                                                         ` Hans-Peter Nilsson
2007-11-30  3:56                                 ` Richard Sandiford
2007-11-30  5:32                                   ` Mark Mitchell
2007-11-30  8:07                                     ` Benjamin Kosnik
2007-11-30  9:58                                   ` Rask Ingemann Lambertsen [this message]
2007-11-30 11:41                                     ` Mark Mitchell
2007-11-30 23:25                                       ` Rask Ingemann Lambertsen
2007-11-30 13:16                                     ` Richard Sandiford
2007-11-30 20:32                                       ` Rask Ingemann Lambertsen
2007-11-30 21:10                                       ` Mark Mitchell
2007-11-30 21:15                                         ` DJ Delorie
2007-12-01  9:55                                         ` Richard Sandiford
2007-12-02 21:01                                           ` Mark Mitchell
2007-12-03 15:55                                             ` Richard Sandiford
2007-12-03 14:40                                     ` btest-gcc.sh patch ping and " Hans-Peter Nilsson
2007-12-03 16:07                                       ` Richard Sandiford
2007-12-03 22:43                                         ` Hans-Peter Nilsson
2007-12-03 16:59                                       ` Geoff Keating
2007-12-03 22:39                                         ` Hans-Peter Nilsson
2007-12-04  6:52                                           ` Geoff Keating
2007-12-04 22:26                                             ` btest-gcc.sh patch ping Hans-Peter Nilsson
2009-03-28 14:10                                             ` btest-gcc.sh patch ping and Re: Link tests after GCC_NO_EXECUTABLES Richard Guenther
2009-03-28 20:37                                               ` Geoff Keating
2007-11-30 20:49                                   ` Rask Ingemann Lambertsen
2008-05-15 21:40                                   ` Bernd Schmidt
2008-05-15 23:02                                     ` Richard Sandiford
2008-05-15 23:10                                       ` Bernd Schmidt
2008-05-16  0:18                                         ` Mark Mitchell
2008-05-16  2:21                                           ` Joseph S. Myers
2008-06-18 21:05                                             ` Ralf Wildenhues
2008-06-19  3:57                                               ` Mark Mitchell
2008-07-07 20:14                                                 ` Ralf Wildenhues
2007-11-28  8:54                       ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071130022132.GL17368@sygehus.dk \
    --to=rask@sygehus.dk \
    --cc=bernds_cb1@t-online.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=hp@gcc.gnu.org \
    --cc=jzhang918@gmail.com \
    --cc=mark@codesourcery.com \
    --cc=rsandifo@nildram.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).