* [PATCH, vax]: remove ASM_FORMAT_PRIVATE_NAME
@ 2007-11-22 8:31 Ben Elliston
2007-11-30 10:36 ` John David Anglin
0 siblings, 1 reply; 2+ messages in thread
From: Ben Elliston @ 2007-11-22 8:31 UTC (permalink / raw)
To: gcc-patches; +Cc: dave.anglin, matt
Hi.
The VAX backend overrides the ASM_FORMAT_PRIVATE_NAME macro for no
reason that I can tell. If the overridden definition is removed, the
default definition will use ASM_PN_FORMAT to format the private name.
As the VAX backend does not define NO_DOT_IN_LABEL or
NO_DOLLAR_IN_LABEL, the default format string of "%s.%lu" will be
chosen. This is fine, I believe.
Okay for mainline?
Ben
2007-11-22 Ben Elliston <bje@au.ibm.com>
* config/vax/vax.h (ASM_FORMAT_PRIVATE_NAME): Remove. Use default.
Index: gcc/config/vax/vax.h
===================================================================
--- gcc/config/vax/vax.h (revision 130335)
+++ gcc/config/vax/vax.h (working copy)
@@ -824,14 +824,6 @@ enum reg_class { NO_REGS, ALL_REGS, LIM_
assemble_name ((FILE), (NAME)), \
fprintf ((FILE), ",%u\n", (int)(ROUNDED)))
-/* Store in OUTPUT a string (made with alloca) containing
- an assembler-name for a local static variable named NAME.
- LABELNO is an integer which is different for each call. */
-
-#define ASM_FORMAT_PRIVATE_NAME(OUTPUT, NAME, LABELNO) \
- ( (OUTPUT) = (char *) alloca (strlen ((NAME)) + 10), \
- sprintf ((OUTPUT), "%s.%d", (NAME), (LABELNO)))
-
/* Print an instruction operand X on file FILE.
CODE is the code from the %-spec that requested printing this operand;
if `%z3' was used to print operand 3, then CODE is 'z'.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, vax]: remove ASM_FORMAT_PRIVATE_NAME
2007-11-22 8:31 [PATCH, vax]: remove ASM_FORMAT_PRIVATE_NAME Ben Elliston
@ 2007-11-30 10:36 ` John David Anglin
0 siblings, 0 replies; 2+ messages in thread
From: John David Anglin @ 2007-11-30 10:36 UTC (permalink / raw)
To: Ben Elliston; +Cc: gcc-patches, dave.anglin, matt
> 2007-11-22 Ben Elliston <bje@au.ibm.com>
>
> * config/vax/vax.h (ASM_FORMAT_PRIVATE_NAME): Remove. Use default.
Ok.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-30 2:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-22 8:31 [PATCH, vax]: remove ASM_FORMAT_PRIVATE_NAME Ben Elliston
2007-11-30 10:36 ` John David Anglin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).