From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26920 invoked by alias); 3 Dec 2007 22:39:15 -0000 Received: (qmail 26909 invoked by uid 22791); 3 Dec 2007 22:39:13 -0000 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.31) with SMTP; Mon, 03 Dec 2007 22:39:07 +0000 Received: (qmail 49931 invoked by uid 20157); 3 Dec 2007 22:39:03 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 3 Dec 2007 22:39:03 -0000 Date: Mon, 03 Dec 2007 22:39:00 -0000 From: Hans-Peter Nilsson To: Geoff Keating cc: Rask Ingemann Lambertsen , GCC Patches Subject: Re: btest-gcc.sh patch ping and Re: Link tests after GCC_NO_EXECUTABLES In-Reply-To: <5B2201B7-4859-46E3-8994-FB1B1EF20A2A@geoffk.org> Message-ID: <20071203172219.I18316@dair.pair.com> References: <474C8FA4.2040603@codesourcery.com> <474C95BA.1060807@t-online.de> <474C96C1.7010208@codesourcery.com> <474C98AA.50105@t-online.de> <474C9A65.2060902@codesourcery.com> <474C9B33.8060503@t-online.de> <474C9CBD.2070708@codesourcery.com> <87fxyqdc45.fsf@firetop.home> <474D943C.4030106@codesourcery.com> <877ik0aerh.fsf@firetop.home> <20071130022132.GL17368@sygehus.dk> <20071203092630.N17510@dair.pair.com> <5B2201B7-4859-46E3-8994-FB1B1EF20A2A@geoffk.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00078.txt.bz2 On Mon, 3 Dec 2007, Geoff Keating wrote: > On Dec 3, 2007, at 6:40 AM, Hans-Peter Nilsson wrote: > > 2 - btest-gcc.sh isn't updated to cover fortran. > > Patch at . Ping! > > Rejected; I do not think this script needs to be configurable in this fashion. But *I* do. As it doesn't affect the default functionality or the integrity of the result (everything still listed in build_log), and doesn't take away or add redundant functionality, I don't really understand your rejection. > If there's a log missing, and you think the underlying functionality is stable > and well supported by GCC contributors on all platforms where it is enabled, > propose a patch to add it. The fortran tests are stable where it works, or so it seems. Whether it works is port-specific (build issue on *-elf being covered in this thread), and the patch above was a way to add the functionality per-platform. It would also allow e.g. tracking gas or ld results in a combined tree. I just need a regtest-script I can point to, such that people can see how I build and regtest and possibly repeat it. Your btest-gcc.sh mostly fits, but not covering all gcc-related tests that run by "make check" is really an issue. I guess I could solve that by adding a variant of that script in contrib/ though I do prefer improving the existing one. brgds, H-P