Re: [PATCH] cleanups for reduction code (autopar pass)

[Zdenek Dvorak <rakdver@kam.mff.cuni.cz>]

Hi,

>     htab_traverse (reduction_list, create_call_for_reduction_1, ld_st_data);
>   }
> 
> ! /* Callback for htab_traverse.  Loads the final reduction value at the
> !    join point of all threads , and inserts it in the right place.  */
> 
>   static int
>   create_loads_for_reductions (void **slot, void *data)

remove the space before commam

> --- 988,994 ----
>       build_gimple_modify_stmt (build3
>                                 (COMPONENT_REF, type, clsn_data->store,
>                                  red->field, NULL_TREE),
> !                                red->initial_value );
>     mark_virtual_ops_for_renaming (stmt);
>     bsi_insert_after (&bsi, stmt, BSI_NEW_STMT);

and the one before )

> *************** separate_decls_in_loop (struct loop *loo
> *** 1168,1175 ****
>         htab_traverse (name_copies, create_loads_and_stores_for_name,
>   		     ld_st_data);
> 
> !       /* Load the calculation from memory into a new
> !          reduction variable (after the join of the threads).  */
>         if (htab_elements (reduction_list) > 0)
>   	{
>   	  htab_traverse (reduction_list, create_stores_for_reduction,
> --- 1135,1142 ----
>         htab_traverse (name_copies, create_loads_and_stores_for_name,
>   		     ld_st_data);
> 
> !       /* Load the calculation from memory
> !          (after the join of the threads).  */
>         if (htab_elements (reduction_list) > 0)

Don't wrap the line in the comment.

Otherwise OK.

Zdenek