From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6350 invoked by alias); 6 Dec 2007 23:20:37 -0000 Received: (qmail 6334 invoked by uid 22791); 6 Dec 2007 23:20:36 -0000 X-Spam-Check-By: sourceware.org Received: from nikam-dmz.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 06 Dec 2007 23:20:32 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 29025) id 23C6A5BA16; Fri, 7 Dec 2007 00:20:30 +0100 (CET) Date: Thu, 06 Dec 2007 23:20:00 -0000 From: Zdenek Dvorak To: Razya Ladelsky Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cleanups for reduction code (autopar pass) Message-ID: <20071206232030.GB32101@kam.mff.cuni.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00303.txt.bz2 Hi, > htab_traverse (reduction_list, create_call_for_reduction_1, ld_st_data); > } > > ! /* Callback for htab_traverse. Loads the final reduction value at the > ! join point of all threads , and inserts it in the right place. */ > > static int > create_loads_for_reductions (void **slot, void *data) remove the space before commam > --- 988,994 ---- > build_gimple_modify_stmt (build3 > (COMPONENT_REF, type, clsn_data->store, > red->field, NULL_TREE), > ! red->initial_value ); > mark_virtual_ops_for_renaming (stmt); > bsi_insert_after (&bsi, stmt, BSI_NEW_STMT); and the one before ) > *************** separate_decls_in_loop (struct loop *loo > *** 1168,1175 **** > htab_traverse (name_copies, create_loads_and_stores_for_name, > ld_st_data); > > ! /* Load the calculation from memory into a new > ! reduction variable (after the join of the threads). */ > if (htab_elements (reduction_list) > 0) > { > htab_traverse (reduction_list, create_stores_for_reduction, > --- 1135,1142 ---- > htab_traverse (name_copies, create_loads_and_stores_for_name, > ld_st_data); > > ! /* Load the calculation from memory > ! (after the join of the threads). */ > if (htab_elements (reduction_list) > 0) Don't wrap the line in the comment. Otherwise OK. Zdenek