[PATCH] ada: Use explicit conversion to VString_Ptr

[PATCH] ada: Use explicit conversion to VString_Ptr

[Samuel Tardieu]

Replace .all'Unchecked_Access by an explicit conversion to VString_Ptr,
as is done in BreakX already.

    gcc/ada/
	* g-spipat.adb (Break): Use explicit conversion to VString_Ptr.
---
 gcc/ada/g-spipat.adb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gcc/ada/g-spipat.adb b/gcc/ada/g-spipat.adb
index 0e56f8a..dc487de 100644
--- a/gcc/ada/g-spipat.adb
+++ b/gcc/ada/g-spipat.adb
@@ -1812,7 +1812,7 @@ package body GNAT.Spitbol.Patterns is
    function Break (Str : not null access VString) return Pattern is
    begin
       return (AFC with 0,
-              new PE'(PC_Break_VP, 1, EOP, Str.all'Unchecked_Access));
+              new PE'(PC_Break_VP, 1, EOP, VString_Ptr (Str)));
    end Break;
 
    function Break (Str : VString_Func) return Pattern is
-- 
1.5.3.7

Re: [PATCH] ada: Use explicit conversion to VString_Ptr

[Arnaud Charlet]

> Replace .all'Unchecked_Access by an explicit conversion to VString_Ptr,
> as is done in BreakX already.
> 
>     gcc/ada/
> 	* g-spipat.adb (Break): Use explicit conversion to VString_Ptr.

No, this change is wrong. We just did exactly the opposite of that for good
reasons, see the message I just sent on gcc-patches
([Ada] Fix accessibility error in GNAT.Spitbol.Patterns), and
see svn log/svn annotate.

Arno

Re: [PATCH] ada: Use explicit conversion to VString_Ptr

[Samuel Tardieu]

On 13/12, Arnaud Charlet wrote:

| > Replace .all'Unchecked_Access by an explicit conversion to VString_Ptr,
| > as is done in BreakX already.
| > 
| >     gcc/ada/
| > 	* g-spipat.adb (Break): Use explicit conversion to VString_Ptr.
| 
| No, this change is wrong. We just did exactly the opposite of that for good
| reasons, see the message I just sent on gcc-patches
| ([Ada] Fix accessibility error in GNAT.Spitbol.Patterns), and
| see svn log/svn annotate.

Ok, it got caught by the -gnatw.u warning; if Unchecked_Access is indeed
mandatory here, the -gnatw.u patch may be missing a corner case.

Re: [PATCH] ada: Use explicit conversion to VString_Ptr

[Robert Dewar]

Samuel Tardieu wrote:
> On 13/12, Arnaud Charlet wrote:
> 
> | > Replace .all'Unchecked_Access by an explicit conversion to VString_Ptr,
> | > as is done in BreakX already.
> | > 
> | >     gcc/ada/
> | > 	* g-spipat.adb (Break): Use explicit conversion to VString_Ptr.
> | 
> | No, this change is wrong. We just did exactly the opposite of that for good
> | reasons, see the message I just sent on gcc-patches
> | ([Ada] Fix accessibility error in GNAT.Spitbol.Patterns), and
> | see svn log/svn annotate.
> 
> Ok, it got caught by the -gnatw.u warning; if Unchecked_Access is indeed
> mandatory here, the -gnatw.u patch may be missing a corner case.

This makes me worry about that patch. I really think we should redo this
using my approach, which is for sure reliable.

Re: [PATCH] ada: Use explicit conversion to VString_Ptr

[Arnaud Charlet]

> >Ok, it got caught by the -gnatw.u warning; if Unchecked_Access is indeed
> >mandatory here, the -gnatw.u patch may be missing a corner case.
> 
> This makes me worry about that patch. I really think we should redo this
> using my approach, which is for sure reliable.

Agreed, sounds like the -gnatw.u warning is dangerous as it is.

Arno