From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6733 invoked by alias); 14 Dec 2007 11:51:58 -0000 Received: (qmail 6723 invoked by uid 22791); 14 Dec 2007 11:51:58 -0000 X-Spam-Check-By: sourceware.org Received: from nic2.axis.se (HELO krynn.se.axis.com) (193.13.178.10) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Dec 2007 11:51:53 +0000 Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.83.5.18]) by krynn.se.axis.com (8.13.4/8.13.4/Debian-3sarge3) with ESMTP id lBEBpo9u003538; Fri, 14 Dec 2007 12:51:50 +0100 Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id lBEBpofm011645; Fri, 14 Dec 2007 12:51:50 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id lBEBpnP7011641; Fri, 14 Dec 2007 12:51:49 +0100 Date: Fri, 14 Dec 2007 12:02:00 -0000 Message-Id: <200712141151.lBEBpnP7011641@ignucius.se.axis.com> From: Hans-Peter Nilsson To: stevenb.gcc@gmail.com CC: hans-peter.nilsson@axis.com, aldyh@redhat.com, gcc-patches@gcc.gnu.org In-reply-to: <571f6b510712132325u2db2bf35g32152a11ea8049b4@mail.gmail.com> (stevenb.gcc@gmail.com) Subject: Re: PR33713: remove -fforce-addr Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00655.txt.bz2 > Date: Fri, 14 Dec 2007 08:25:11 +0100 > From: "Steven Bosscher" > On Dec 14, 2007 2:57 AM, Hans-Peter Nilsson wrote: > > > Date: Tue, 4 Dec 2007 19:13:35 -0400 > > > From: Aldy Hernandez > > > > > > Anyway, the point of this communication: was it really a good > > > > thing to remove all test-cases using -fforce-addr? Why not just > > > > remove their -fforce-addr argument? Can we add them back? > > > > > > I don't have a problem with that. Steven? > > > > Any news on this? > > IMHO without -fforce-addr the test cases test nothing that isn't > already triggered by a gcc build or by another test case. I see no > point in keeping aruond test cases that add no test coverage. You're quick with your dismissals. When removing -fforce-addr, code was changed that at least formerly was exercised by the test-cases. As a result of that change, the generated code changed, so without further analysis (as to whether the execution path now actually is exercised by *these* tests), keeping the test-cases trivially make sense. Agree? brgds, H-P