public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH,RFA] Fix error with arm_vector_mode_supported_p()
@ 2007-12-05 13:44 Bernhard Fischer
  2007-12-15 16:33 ` Bernhard Fischer
  0 siblings, 1 reply; 3+ messages in thread
From: Bernhard Fischer @ 2007-12-05 13:44 UTC (permalink / raw)
  To: gcc-patches; +Cc: rep.dot.nop

[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]

Hi,

The following patchlet attempts to fix compilation of insn-opinit.c
on arm for a native compiler.

    Error was (on arm, xscale):
    ... -o libbackend.o  \
              -DBASEVER="\"4.3.0\"" -DDATESTAMP="\" 20071127\"" \
              -DREVISION= \
              -DDEVPHASE="\" (experimental)\"" -DPKGVERSION="\"(GCC) \"" \
              -DBUGURL="\"<http://gcc.gnu.org/bugs.html>\"" -combine
    insn-opinit.c: In function 'init_all_optabs':
    insn-opinit.c:443: warning: implicit declaration of function 'arm_vector_mode_supported_p'
    /there/toolchain_build_arm_nofpu/gcc-4.3.0/gcc/config/arm/arm-protos.h:47: note: previous declaration of 'arm_vector_mode_supported_p' was here
    insn-opinit.c:443: error: incompatible implicit declaration of function 'arm_vector_mode_supported_p'

The compiler was configured via:
/there/toolchain_build_arm_nofpu/gcc-4.3.0/configure \
                --prefix=/usr \
                --build=i386-pc-linux-gnu \
                --host=arm-linux-uclibcgnueabi \
                --target=arm-linux-uclibcgnueabi \
                --enable-languages=c,fortran \
                --with-gxx-include-dir=/usr/include/c++ \
                --disable-__cxa_atexit \
                --with-gnu-ld \
                --enable-shared \
                --with-gmp="/there/build_arm_nofpu/gmp-4.2.2" \
                --with-mpfr="/there/build_arm_nofpu/mpfr-2.3.0" \
                --disable-nls \
                --enable-threads \
                --disable-multilib \
                --with-float=soft \
                --enable-intermodule

The patch leaves the warning about the implicit decl of
arm_vector_mode_supported_p, though.
Please consider fixing.

gcc/ChangeLog
2007-11-27  Bernhard Fischer  <>

	* config/arm/arm-protos.h (arm_vector_mode_supported_p,
	arm_hard_regno_mode_ok, const_ok_for_arm): Do not hide non-rtx related
	function prototypes in RTX_CODE.
	* genopinit.c: Include tm_p.h.

[-- Attachment #2: 993-arm_insn-opinit-RTX_CODE-fixup.diff --]
[-- Type: text/x-diff, Size: 1532 bytes --]

gcc/ChangeLog
2007-11-27  Bernhard Fischer  <>

	* config/arm/arm-protos.h (arm_vector_mode_supported_p,
	arm_hard_regno_mode_ok, const_ok_for_arm): Do not hide non-rtx related
	function prototypes in RTX_CODE.
	* genopinit.c: Include tm_p.h.

Index: gcc-4.3.0/gcc/config/arm/arm-protos.h
===================================================================
--- gcc-4.3.0/gcc/config/arm/arm-protos.h	(revision 130463)
+++ gcc-4.3.0/gcc/config/arm/arm-protos.h	(working copy)
@@ -40,15 +40,14 @@
 							       unsigned int);
 extern unsigned int arm_dbx_register_number (unsigned int);
 extern void arm_output_fn_unwind (FILE *, bool);
-  
 
 #ifdef TREE_CODE
 extern int arm_return_in_memory (const_tree);
 #endif
-#ifdef RTX_CODE
 extern bool arm_vector_mode_supported_p (enum machine_mode);
 extern int arm_hard_regno_mode_ok (unsigned int, enum machine_mode);
 extern int const_ok_for_arm (HOST_WIDE_INT);
+#ifdef RTX_CODE
 extern int arm_split_constant (RTX_CODE, enum machine_mode, rtx,
 			       HOST_WIDE_INT, rtx, rtx, int);
 extern RTX_CODE arm_canonicalize_comparison (RTX_CODE, enum machine_mode,
Index: gcc-4.3.0/gcc/genopinit.c
===================================================================
--- gcc-4.3.0/gcc/genopinit.c	(revision 130463)
+++ gcc-4.3.0/gcc/genopinit.c	(working copy)
@@ -486,6 +486,7 @@
   printf ("#include \"expr.h\"\n");
   printf ("#include \"optabs.h\"\n");
   printf ("#include \"reload.h\"\n\n");
+  printf ("#include \"tm_p.h\"\n\n");
 
   printf ("void\ninit_all_optabs (void)\n{\n");
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH,RFA] Fix error with arm_vector_mode_supported_p()
  2007-12-05 13:44 [PATCH,RFA] Fix error with arm_vector_mode_supported_p() Bernhard Fischer
@ 2007-12-15 16:33 ` Bernhard Fischer
  2007-12-26 20:53   ` Mark Mitchell
  0 siblings, 1 reply; 3+ messages in thread
From: Bernhard Fischer @ 2007-12-15 16:33 UTC (permalink / raw)
  To: gcc-patches; +Cc: rep.dot.nop

ping

On Wed, Dec 05, 2007 at 02:44:08PM +0100, Bernhard Fischer wrote:
>Hi,
>
>The following patchlet attempts to fix compilation of insn-opinit.c
>on arm for a native compiler.
>
>    Error was (on arm, xscale):
>    ... -o libbackend.o  \
>              -DBASEVER="\"4.3.0\"" -DDATESTAMP="\" 20071127\"" \
>              -DREVISION= \
>              -DDEVPHASE="\" (experimental)\"" -DPKGVERSION="\"(GCC) \"" \
>              -DBUGURL="\"<http://gcc.gnu.org/bugs.html>\"" -combine
>    insn-opinit.c: In function 'init_all_optabs':
>    insn-opinit.c:443: warning: implicit declaration of function 'arm_vector_mode_supported_p'
>    /there/toolchain_build_arm_nofpu/gcc-4.3.0/gcc/config/arm/arm-protos.h:47: note: previous declaration of 'arm_vector_mode_supported_p' was here
>    insn-opinit.c:443: error: incompatible implicit declaration of function 'arm_vector_mode_supported_p'
>
>The compiler was configured via:
>/there/toolchain_build_arm_nofpu/gcc-4.3.0/configure \
>                --prefix=/usr \
>                --build=i386-pc-linux-gnu \
>                --host=arm-linux-uclibcgnueabi \
>                --target=arm-linux-uclibcgnueabi \
>                --enable-languages=c,fortran \
>                --with-gxx-include-dir=/usr/include/c++ \
>                --disable-__cxa_atexit \
>                --with-gnu-ld \
>                --enable-shared \
>                --with-gmp="/there/build_arm_nofpu/gmp-4.2.2" \
>                --with-mpfr="/there/build_arm_nofpu/mpfr-2.3.0" \
>                --disable-nls \
>                --enable-threads \
>                --disable-multilib \
>                --with-float=soft \
>                --enable-intermodule
>
>The patch leaves the warning about the implicit decl of
>arm_vector_mode_supported_p, though.
>Please consider fixing.
>
>gcc/ChangeLog
>2007-11-27  Bernhard Fischer  <>
>
>	* config/arm/arm-protos.h (arm_vector_mode_supported_p,
>	arm_hard_regno_mode_ok, const_ok_for_arm): Do not hide non-rtx related
>	function prototypes in RTX_CODE.
>	* genopinit.c: Include tm_p.h.

>gcc/ChangeLog
>2007-11-27  Bernhard Fischer  <>
>
>	* config/arm/arm-protos.h (arm_vector_mode_supported_p,
>	arm_hard_regno_mode_ok, const_ok_for_arm): Do not hide non-rtx related
>	function prototypes in RTX_CODE.
>	* genopinit.c: Include tm_p.h.
>
>Index: gcc-4.3.0/gcc/config/arm/arm-protos.h
>===================================================================
>--- gcc-4.3.0/gcc/config/arm/arm-protos.h	(revision 130463)
>+++ gcc-4.3.0/gcc/config/arm/arm-protos.h	(working copy)
>@@ -40,15 +40,14 @@
> 							       unsigned int);
> extern unsigned int arm_dbx_register_number (unsigned int);
> extern void arm_output_fn_unwind (FILE *, bool);
>-  
> 
> #ifdef TREE_CODE
> extern int arm_return_in_memory (const_tree);
> #endif
>-#ifdef RTX_CODE
> extern bool arm_vector_mode_supported_p (enum machine_mode);
> extern int arm_hard_regno_mode_ok (unsigned int, enum machine_mode);
> extern int const_ok_for_arm (HOST_WIDE_INT);
>+#ifdef RTX_CODE
> extern int arm_split_constant (RTX_CODE, enum machine_mode, rtx,
> 			       HOST_WIDE_INT, rtx, rtx, int);
> extern RTX_CODE arm_canonicalize_comparison (RTX_CODE, enum machine_mode,
>Index: gcc-4.3.0/gcc/genopinit.c
>===================================================================
>--- gcc-4.3.0/gcc/genopinit.c	(revision 130463)
>+++ gcc-4.3.0/gcc/genopinit.c	(working copy)
>@@ -486,6 +486,7 @@
>   printf ("#include \"expr.h\"\n");
>   printf ("#include \"optabs.h\"\n");
>   printf ("#include \"reload.h\"\n\n");
>+  printf ("#include \"tm_p.h\"\n\n");
> 
>   printf ("void\ninit_all_optabs (void)\n{\n");
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH,RFA] Fix error with arm_vector_mode_supported_p()
  2007-12-15 16:33 ` Bernhard Fischer
@ 2007-12-26 20:53   ` Mark Mitchell
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Mitchell @ 2007-12-26 20:53 UTC (permalink / raw)
  To: Bernhard Fischer, Paul Brook; +Cc: gcc-patches

Bernhard Fischer wrote:
> ping

Paul, would you please review this patch?

> On Wed, Dec 05, 2007 at 02:44:08PM +0100, Bernhard Fischer wrote:
>> Hi,
>>
>> The following patchlet attempts to fix compilation of insn-opinit.c
>> on arm for a native compiler.
>>
>>    Error was (on arm, xscale):
>>    ... -o libbackend.o  \
>>              -DBASEVER="\"4.3.0\"" -DDATESTAMP="\" 20071127\"" \
>>              -DREVISION= \
>>              -DDEVPHASE="\" (experimental)\"" -DPKGVERSION="\"(GCC) \"" \
>>              -DBUGURL="\"<http://gcc.gnu.org/bugs.html>\"" -combine
>>    insn-opinit.c: In function 'init_all_optabs':
>>    insn-opinit.c:443: warning: implicit declaration of function 'arm_vector_mode_supported_p'
>>    /there/toolchain_build_arm_nofpu/gcc-4.3.0/gcc/config/arm/arm-protos.h:47: note: previous declaration of 'arm_vector_mode_supported_p' was here
>>    insn-opinit.c:443: error: incompatible implicit declaration of function 'arm_vector_mode_supported_p'
>>
>> The compiler was configured via:
>> /there/toolchain_build_arm_nofpu/gcc-4.3.0/configure \
>>                --prefix=/usr \
>>                --build=i386-pc-linux-gnu \
>>                --host=arm-linux-uclibcgnueabi \
>>                --target=arm-linux-uclibcgnueabi \
>>                --enable-languages=c,fortran \
>>                --with-gxx-include-dir=/usr/include/c++ \
>>                --disable-__cxa_atexit \
>>                --with-gnu-ld \
>>                --enable-shared \
>>                --with-gmp="/there/build_arm_nofpu/gmp-4.2.2" \
>>                --with-mpfr="/there/build_arm_nofpu/mpfr-2.3.0" \
>>                --disable-nls \
>>                --enable-threads \
>>                --disable-multilib \
>>                --with-float=soft \
>>                --enable-intermodule
>>
>> The patch leaves the warning about the implicit decl of
>> arm_vector_mode_supported_p, though.
>> Please consider fixing.
>>
>> gcc/ChangeLog
>> 2007-11-27  Bernhard Fischer  <>
>>
>> 	* config/arm/arm-protos.h (arm_vector_mode_supported_p,
>> 	arm_hard_regno_mode_ok, const_ok_for_arm): Do not hide non-rtx related
>> 	function prototypes in RTX_CODE.
>> 	* genopinit.c: Include tm_p.h.
> 
>> gcc/ChangeLog
>> 2007-11-27  Bernhard Fischer  <>
>>
>> 	* config/arm/arm-protos.h (arm_vector_mode_supported_p,
>> 	arm_hard_regno_mode_ok, const_ok_for_arm): Do not hide non-rtx related
>> 	function prototypes in RTX_CODE.
>> 	* genopinit.c: Include tm_p.h.
>>
>> Index: gcc-4.3.0/gcc/config/arm/arm-protos.h
>> ===================================================================
>> --- gcc-4.3.0/gcc/config/arm/arm-protos.h	(revision 130463)
>> +++ gcc-4.3.0/gcc/config/arm/arm-protos.h	(working copy)
>> @@ -40,15 +40,14 @@
>> 							       unsigned int);
>> extern unsigned int arm_dbx_register_number (unsigned int);
>> extern void arm_output_fn_unwind (FILE *, bool);
>> -  
>>
>> #ifdef TREE_CODE
>> extern int arm_return_in_memory (const_tree);
>> #endif
>> -#ifdef RTX_CODE
>> extern bool arm_vector_mode_supported_p (enum machine_mode);
>> extern int arm_hard_regno_mode_ok (unsigned int, enum machine_mode);
>> extern int const_ok_for_arm (HOST_WIDE_INT);
>> +#ifdef RTX_CODE
>> extern int arm_split_constant (RTX_CODE, enum machine_mode, rtx,
>> 			       HOST_WIDE_INT, rtx, rtx, int);
>> extern RTX_CODE arm_canonicalize_comparison (RTX_CODE, enum machine_mode,
>> Index: gcc-4.3.0/gcc/genopinit.c
>> ===================================================================
>> --- gcc-4.3.0/gcc/genopinit.c	(revision 130463)
>> +++ gcc-4.3.0/gcc/genopinit.c	(working copy)
>> @@ -486,6 +486,7 @@
>>   printf ("#include \"expr.h\"\n");
>>   printf ("#include \"optabs.h\"\n");
>>   printf ("#include \"reload.h\"\n\n");
>> +  printf ("#include \"tm_p.h\"\n\n");
>>
>>   printf ("void\ninit_all_optabs (void)\n{\n");
>>
> 


-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-12-26 19:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-05 13:44 [PATCH,RFA] Fix error with arm_vector_mode_supported_p() Bernhard Fischer
2007-12-15 16:33 ` Bernhard Fischer
2007-12-26 20:53   ` Mark Mitchell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).