[PATCH] Fix PR34025: wrong architecture object files in multilib

[PATCH] Fix PR34025: wrong architecture object files in multilib

[Jack Howarth]

The attached patch fixes PR34025. The object files for
crtfastmath.o, crtprec32.o, crtprec64.o and crtprec80.o
were being created with the wrong architecture for the
multilib build on i686-apple-darwin9. This was due to
the absence of $(MULTILIB_CFLAGS) on their build
commands. Tested on i686-apple-darwin9 and eliminates
92 gcc testsuite regressions at -m64. Okay for trunk?
                        Jack

2007-12-16  Jack Howarth  <howarth@bromo.med.uc.edu>

	PR target/34025
	* gcc/config/i386/t-crtpc: Add $(MULTILIB_CFLAGS).
	* gcc/config/i386/t-crtfm: Likewise.


Index: gcc/config/i386/t-crtpc
===================================================================
--- gcc/config/i386/t-crtpc	(revision 130986)
+++ gcc/config/i386/t-crtpc	(working copy)
@@ -1,16 +1,16 @@
 EXTRA_PARTS += crtprec32.o crtprec64.o crtprec80.o
 
 $(T)crtprec32.o: $(srcdir)/config/i386/crtprec.c $(GCC_PASSES)
-	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) -D__PREC=32 -c \
+	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) $(MULTILIB_CFLAGS) -D__PREC=32 -c \
 		$(srcdir)/config/i386/crtprec.c \
 		-o $(T)crtprec32$(objext)
 
 $(T)crtprec64.o: $(srcdir)/config/i386/crtprec.c $(GCC_PASSES)
-	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) -D__PREC=64 -c \
+	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) $(MULTILIB_CFLAGS) -D__PREC=64 -c \
 		$(srcdir)/config/i386/crtprec.c \
 		-o $(T)crtprec64$(objext)
 
 $(T)crtprec80.o: $(srcdir)/config/i386/crtprec.c $(GCC_PASSES)
-	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) -D__PREC=80 -c \
+	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) $(MULTILIB_CFLAGS) -D__PREC=80 -c \
 		$(srcdir)/config/i386/crtprec.c \
 		-o $(T)crtprec80$(objext)
Index: gcc/config/i386/t-crtfm
===================================================================
--- gcc/config/i386/t-crtfm	(revision 130986)
+++ gcc/config/i386/t-crtfm	(working copy)
@@ -2,6 +2,6 @@ EXTRA_PARTS += crtfastmath.o
 
 $(T)crtfastmath.o: $(srcdir)/config/i386/crtfastmath.c \
   $(srcdir)/config/i386/cpuid.h $(GCC_PASSES)
-	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) -msse -minline-all-stringops -c \
+	$(GCC_FOR_TARGET) $(LIBGCC2_CFLAGS) $(MULTILIB_CFLAGS) -msse -minline-all-stringops -c \
 		$(srcdir)/config/i386/crtfastmath.c \
 		-o $(T)crtfastmath$(objext)

Re: [PATCH] Fix PR34025: wrong architecture object files in multilib

[Jack Howarth]

Uros,
    The gcc 4.2.2 release doesn't have this issue since we
don't seem to build those particular object files. Can
you do the checkin of the patch to gcc trunk? Thanks in
advance.
              Jack

On Sun, Dec 16, 2007 at 10:41:52PM +0100, Uros Bizjak wrote:
> Hello!
>
>> 2007-12-16  Jack Howarth  <howarth@bromo.med.uc.edu>
>>
>> 	PR target/34025
>> 	* gcc/config/i386/t-crtpc: Add $(MULTILIB_CFLAGS).
>> 	* gcc/config/i386/t-crtfm: Likewise.
>
> This is OK for 4.3.  Does your target also needs this for 4.2?
>
> Thanks,
> Uros.

Re: [PATCH] Fix PR34025: wrong architecture object files in multilib

[Uros Bizjak]

Hello!

> 2007-12-16  Jack Howarth  <howarth@bromo.med.uc.edu>
>
> 	PR target/34025
> 	* gcc/config/i386/t-crtpc: Add $(MULTILIB_CFLAGS).
> 	* gcc/config/i386/t-crtfm: Likewise.

This is OK for 4.3.  Does your target also needs this for 4.2?

Thanks,
Uros.