public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Daniel Richard G." <skunk@iSKUNK.ORG>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Check for valid value of BASEVER
Date: Thu, 14 Feb 2008 20:15:00 -0000	[thread overview]
Message-ID: <20080214195846.GA3085@iSKUNK.ORG> (raw)

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

In the event of a missing or mis-read $(top_srcdir)/gcc/BASE-VER file, this 
patch (against 4.2.3) will cause gcc/Makefile to throw an immediate error, 
instead of allowing the bootstrap process to continue on to an eventual ICE 
(due to an empty version string, in regular GCC releases).

See the Bugzilla entry for some more background on this:

	http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35199

Please Cc: any replies to me, as I am not subscribed to this list.


--Daniel


-- 
NAME   = Daniel Richard G.       ##  Remember, skunks       _\|/_  meef?
EMAIL1 = skunk@iskunk.org        ##  don't smell bad---    (/o|o\) /
EMAIL2 = skunk@alum.mit.edu      ##  it's the people who   < (^),>
WWW    = http://www.******.org/  ##  annoy them that do!    /   \
--
(****** = site not yet online)

[-- Attachment #2: gcc.patch --]
[-- Type: text/x-diff, Size: 486 bytes --]

diff -ru gcc-4.2.3/gcc/Makefile.in gcc-4.2.3-patched/gcc/Makefile.in
--- gcc-4.2.3/gcc/Makefile.in	2007-10-31 12:32:06.000000000 -0400
+++ gcc-4.2.3-patched/gcc/Makefile.in	2008-02-14 12:21:51.000000000 -0500
@@ -735,6 +735,10 @@
 DEVPHASE_c  := $(shell cat $(DEVPHASE))
 DATESTAMP_c := $(shell cat $(DATESTAMP))
 
+ifeq ($(BASEVER_c),)
+$(error $(BASEVER): missing version file)
+endif
+
 version     := $(BASEVER_c)
 
 # For use in version.c - double quoted strings, with appropriate

                 reply	other threads:[~2008-02-14 19:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080214195846.GA3085@iSKUNK.ORG \
    --to=skunk@iskunk.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).