From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2172 invoked by alias); 14 Feb 2008 19:59:17 -0000 Received: (qmail 2162 invoked by uid 22791); 14 Feb 2008 19:59:16 -0000 X-Spam-Check-By: sourceware.org Received: from smarty.dreamhost.com (HELO smarty.dreamhost.com) (208.113.175.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Feb 2008 19:58:52 +0000 Received: from fusion (dib.dreamhost.com [66.33.213.17]) by smarty.dreamhost.com (Postfix) with ESMTP id 4B910EE24A for ; Thu, 14 Feb 2008 11:58:49 -0800 (PST) Date: Thu, 14 Feb 2008 20:15:00 -0000 From: "Daniel Richard G." To: gcc-patches@gcc.gnu.org Subject: [PATCH] Check for valid value of BASEVER Message-ID: <20080214195846.GA3085@iSKUNK.ORG> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline X-Image-URL: http://www.iskunk.org/face.jpg Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-02/txt/msg00514.txt.bz2 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 793 In the event of a missing or mis-read $(top_srcdir)/gcc/BASE-VER file, this patch (against 4.2.3) will cause gcc/Makefile to throw an immediate error, instead of allowing the bootstrap process to continue on to an eventual ICE (due to an empty version string, in regular GCC releases). See the Bugzilla entry for some more background on this: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35199 Please Cc: any replies to me, as I am not subscribed to this list. --Daniel -- NAME = Daniel Richard G. ## Remember, skunks _\|/_ meef? EMAIL1 = skunk@iskunk.org ## don't smell bad--- (/o|o\) / EMAIL2 = skunk@alum.mit.edu ## it's the people who < (^),> WWW = http://www.******.org/ ## annoy them that do! / \ -- (****** = site not yet online) --tThc/1wpZn/ma/RB Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="gcc.patch" Content-length: 486 diff -ru gcc-4.2.3/gcc/Makefile.in gcc-4.2.3-patched/gcc/Makefile.in --- gcc-4.2.3/gcc/Makefile.in 2007-10-31 12:32:06.000000000 -0400 +++ gcc-4.2.3-patched/gcc/Makefile.in 2008-02-14 12:21:51.000000000 -0500 @@ -735,6 +735,10 @@ DEVPHASE_c := $(shell cat $(DEVPHASE)) DATESTAMP_c := $(shell cat $(DATESTAMP)) +ifeq ($(BASEVER_c),) +$(error $(BASEVER): missing version file) +endif + version := $(BASEVER_c) # For use in version.c - double quoted strings, with appropriate --tThc/1wpZn/ma/RB--