public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Richard Guenther <richard.guenther@gmail.com>,
	        "Joseph S. Myers" <joseph@codesourcery.com>,
	        GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC] PR34389 -Wconversion produces wrong warning
Date: Mon, 18 Feb 2008 21:37:00 -0000	[thread overview]
Message-ID: <20080218203558.GR24887@devserv.devel.redhat.com> (raw)
In-Reply-To: <6c33472e0802181222h69a09a4by206eb0a49f448f1c@mail.gmail.com>

On Mon, Feb 18, 2008 at 09:22:33PM +0100, Manuel López-Ibáñez wrote:
> On 18/02/2008, Richard Guenther <richard.guenther@gmail.com> wrote:
> >
> > Can you instead completely remove the shorten_binary_op code?  This
> > transformation is already done by fold and thus this code is redundant
> > (and optimization should not happen inside the frontend).
> 
> Done!
> 
> Bootstrapped and regression tested in x86_64-unknown-linux-gnu.
> 
> I keep the function just for conversion_warning, since, as Joseph
> explained, the extended operation may be user code and not the result
> of folding, so we need to deal with it. I guess that for this purpose
> the function can be greatly simplified, but I would like to know
> whether this is the right approach.

Can you add testcases to make sure the optimizations you are removing from
the FEs really happen at gimplification time?
I think testsuite/g**.dg/tree-ssa/* tests with -fdump-tree-gimple pattern
matching would be appropriate.

	Jakub

  reply	other threads:[~2008-02-18 20:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16 17:00 Manuel López-Ibáñez
2008-02-16 17:05 ` Richard Guenther
2008-02-16 17:42   ` Manuel López-Ibáñez
2008-02-16 17:50     ` Richard Guenther
2008-02-16 18:31       ` Manuel López-Ibáñez
2008-02-16 18:53         ` Richard Guenther
2008-02-17 16:44           ` Manuel López-Ibáñez
2008-02-17 17:51             ` Richard Guenther
2008-02-18  1:21   ` Joseph S. Myers
2008-02-18 15:48     ` Manuel López-Ibáñez
2008-02-18 17:10       ` Manuel López-Ibáñez
2008-02-18 17:26         ` Richard Guenther
2008-02-18 20:40           ` Manuel López-Ibáñez
2008-02-18 21:37             ` Jakub Jelinek [this message]
2008-02-18 22:11               ` Manuel López-Ibáñez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218203558.GR24887@devserv.devel.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=lopezibanez@gmail.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).