From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31689 invoked by alias); 16 Mar 2008 18:22:46 -0000 Received: (qmail 31680 invoked by uid 22791); 16 Mar 2008 18:22:45 -0000 X-Spam-Check-By: sourceware.org Received: from province.act-europe.fr (HELO province.act-europe.fr) (212.99.106.214) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Mar 2008 18:22:23 +0000 Received: by province.act-europe.fr (Postfix, from userid 525) id 59FCB166CC2; Sun, 16 Mar 2008 19:22:10 +0100 (CET) Date: Sun, 16 Mar 2008 18:32:00 -0000 From: Arnaud Charlet To: Ralf Wildenhues , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ADA, DOC] PR 15479: Crossrefs and links Message-ID: <20080316182210.GA37514@adacore.com> References: <20080315135145.GG17579@ins.uni-bonn.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080315135145.GG17579@ins.uni-bonn.de> User-Agent: Mutt/1.4.2.2i X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00981.txt.bz2 > Right now, there is one crucial limitation to this patch: references > from the Reference Manual to the User Manual have the name gnat_ugn_unw > hard-coded; so it amounts to the wrong thing on VMS, I suppose. Lifting > this limitation would require some preprocessing of gnat_rm.texi similar > to how gnat_ugn.texi is preprocessed, because texinfo doesn't like > @value's in the info-file-name argument of cross-references.[1] > Should I add that? Hard coding the name is indeed not desirable and should be addressed before doing this change. > Smaller issues regarding this patch: > > - gnat_rm.texi, node "Pragma Long_Float", refers to gnatlbr, > a node which exists in the VMS version of the User's Manual only. > I suppose this may be fixed along with above. Sounds like a good idea. > - gnat_ugn.texi, node "Ada tasks", refers to "tasking support" > inside GDB. Should that link to the node "Threads" in gdb? No, the ref is indeed to Ada tasks. > FWIW, my gdb does not understand the command "info tasks" at all, > which is explicitly documented in gnat_ugn. That's indeed related. I do not know the state of the Ada specific documentation in gdb, so this refers to GNAt additions that may not yet be at the FSF, although will appear at some point if not already. > OK for trunk and 4.3? Not in the current form. I'd suggest resubmitting a patch with the tricky parts left aside for now, so that 90% of your changes can be OKed. You can then work on the remaining 10% when you get a chance. Arno