Re: [patch, fortran]PR25829 Add support for F2003 I/O features

[Tobias Burnus <tobias.burnus@physik.fu-berlin.de>]

Hi Jerry,

> The patch is getting too big so i do not want to add any more until we
> get this in trunk,
> With that said, I have attached the latest patch and 7 new test cases.
> OK for trunk.

I think the patch is OK.

I added some more items below, but they can be fixed later.
(a), (b) and (c) are relatively simply, (d) needs more effort.
And (e) can be postponed or included in the (a) to (c) patch.

> I forgot a couple of things.  I still need to version the new symbol in
> gfortran,map and i still need to test for ABI breakage.  I will do this
> while the patch is being reviewed and report back here.

Thanks for remembering this.


a) First test case. The error message of sunf95 is clear and correct
(see C926) (it shows also another error message which is wrong...):

write(10,'(10f8.3)',  decimal="comma", id=j) a
                                          ^
"test.f90", Line = 13, Column = 43: ERROR: This ID= specifier requires
ASYNCHRONOUS='YES' specifier as well.

Expected: A correct test case and an error message
(Don't forget the asynchronous == 'Yes' check.)



b) The following is invalid as asynchronous= in data-transfer statements (!)
requires an initialization expression; see R913. (In OPEN it does not.)

character(len=10) :: a = 'No'
WRITE(*,*,asynchronous=a) ! invalid
END

The reason is to allow for a faster implemenation as this allows to
generate different code in the front end for READ/WRITE with
and without asynchronous.


c)   write(6,*,delim='quote') 'Hello'
Should print  "Hello"  (with quotes) and not Hello



d) INQUIRE has some problems (-> Follow up patch)


Not recognized:  asynchronous=str, decimal=str, encoding=str,
                 pending=<logical>, round=str, sign=str, size=<integer>

inquire(99,id=j)
-> not recognized, but also invalid without pending=<logical>

!-----------------------------------------------------------
implicit none
character(len=10) :: a,b,c,d,e,f
logical :: log
integer :: id,j
inquire(99,asynchronous=a,blank=b,decimal=c,encoding=d,id=id,pending=log, &
           round=E,sign=f,size=j)
print *, 'asynchronous=',a,'  blank=',b,'  decimal=',c,'  encoding=',d, &
         '  id=',id, '  pending=',log,'  round=',E,'  sign=',f,'
size=',j
! Expected: all strings 'UNDEFINED' and pending = .false.
END
!-----------------------------------------------------------



e) rounding edit decriptors (ru, rd, etc.) are not recognized by neither
the back nor the front end. Maybe one could recognize them and error out
with a not-implemented message?

Tobias