From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19776 invoked by alias); 29 Jul 2008 14:36:52 -0000 Received: (qmail 19591 invoked by uid 22791); 29 Jul 2008 14:36:51 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jul 2008 14:36:33 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m6TEaUav000725; Tue, 29 Jul 2008 10:36:30 -0400 Received: from file.rdu.redhat.com (file.rdu.redhat.com [10.11.255.147]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6TEa8M0032480; Tue, 29 Jul 2008 10:36:28 -0400 Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [10.10.36.72]) by file.rdu.redhat.com (8.13.1/8.13.1) with ESMTP id m6TEUK4G030642; Tue, 29 Jul 2008 10:30:20 -0400 Received: from devserv.devel.redhat.com (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id m6TETKH8022669; Tue, 29 Jul 2008 10:29:20 -0400 Received: (from jakub@localhost) by devserv.devel.redhat.com (8.12.11.20060308/8.12.11/Submit) id m6TETKGO022667; Tue, 29 Jul 2008 10:29:20 -0400 Date: Tue, 29 Jul 2008 16:57:00 -0000 From: Jakub Jelinek To: Ian Lance Taylor Cc: Denys Vlasenko , dj@redhat.com, ian@airs.com, gcc-patches@gcc.gnu.org, binutils@sources.redhat.com Subject: Re: [PATCH] gcc cannot deal with full /tmp Message-ID: <20080729142920.GW8133@devserv.devel.redhat.com> Reply-To: Jakub Jelinek References: <200807281911.00146.dvlasenk@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-07/txt/msg02275.txt.bz2 On Tue, Jul 29, 2008 at 07:23:21AM -0700, Ian Lance Taylor wrote: > As far as the patch goes: > * Comments should be complete sentences. > * The fprintf line is too long--it needs to wrap at 80 columns. > * Don't put a comment on the same line as abort (). Also: * Put a space between function name and opening (. * Two spaces between sentences in comments. * Write a ChangeLog entry. Jakub